Bug 2346861

Summary: Review Request: rust-linicon - Look up icons and icon theme info on Linux
Product: [Fedora] Fedora Reporter: Davide Cavalca <davide>
Component: Package ReviewAssignee: Michel Lind <michel>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: michel, package-review
Target Milestone: ---Flags: michel: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/linicon
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-03-04 04:26:53 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2346857, 2346860    
Bug Blocks: 2346879    

Description Davide Cavalca 2025-02-20 17:30:07 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-linicon/rust-linicon.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-linicon/rust-linicon-2.3.0-1.fc43.src.rpm

Description:
Look up icons and icon theme info on Linux.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2025-02-20 17:31:37 UTC
$ cat rust2rpm.toml 
[package]
cargo-toml-patch-comments = [
  "Drop unneeded criterion dependency",
]

[tests]
skip = [
  "tests::do_lookup",
  "tests::do_lookup_no_scale",
  "tests::do_lookup_no_size",
  "tests::do_lookup_no_size_scale",
  "tests::get_themes",
  "tests::move_iter",
  "tests::move_threads",
]
skip-exact = true
comments = ["Skip broken tests"]

Comment 2 Fedora Review Service 2025-02-20 17:31:58 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8676054
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2346861-rust-linicon/fedora-rawhide-x86_64/08676054-rust-linicon/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Michel Lind 2025-03-04 04:15:28 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MPL-2.0) and is acceptable for Fedora
- [BINARY ONLY] licenses of statically linked dependencies are correctly taken into account
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard rust-$crate` to automate):

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

## Review template (compat)

Compat package, looks identical to the existing rust-$crate. APPROVED

Comment 4 Fedora Admin user for bugzilla script actions 2025-03-04 04:16:58 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-linicon

Comment 5 Fedora Update System 2025-03-04 04:24:28 UTC
FEDORA-2025-5e9e5db84a (rust-linicon-2.3.0-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-5e9e5db84a

Comment 6 Fedora Update System 2025-03-04 04:26:53 UTC
FEDORA-2025-5e9e5db84a (rust-linicon-2.3.0-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.