Bug 2346879 - Review Request: rust-freedesktop-icons - Freedesktop Icons lookup crate
Summary: Review Request: rust-freedesktop-icons - Freedesktop Icons lookup crate
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/freedesktop-...
Whiteboard:
Depends On: 2346725 2346726 2346861
Blocks: 2330436
TreeView+ depends on / blocked
 
Reported: 2025-02-20 18:05 UTC by Davide Cavalca
Modified: 2025-05-30 16:01 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-05-30 16:01:01 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2025-02-20 18:05:30 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-freedesktop-icons/rust-freedesktop-icons.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-freedesktop-icons/rust-freedesktop-icons-0.3.1-1.fc43.src.rpm

Description:
A Freedesktop Icons lookup crate.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2025-02-20 18:06:15 UTC
$ cat rust2rpm.toml 
[package]
cargo-toml-patch-comments = [
  "Drop unneeded criterion dependency",
]
extra-patches = [
  { "number" = 2, "file" = "https://github.com/oknozor/freedesktop-icons/pull/25.patch", comments = ["Fix doc tests"] },
]

[tests]
skip = [
  "theme::parse::test::should_get_theme_parents",
  "theme::test::should_get_png_first",
  "theme::test::should_get_svg_first",
]
skip-exact = true
comments = ["Skip broken tests"]

Comment 2 Fedora Review Service 2025-02-20 18:09:28 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8676202
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2346879-rust-freedesktop-icons/fedora-rawhide-x86_64/08676202-rust-freedesktop-icons/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Michel Lind 2025-03-04 04:47:45 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- [BINARY ONLY] licenses of statically linked dependencies are correctly taken into account
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard rust-$crate` to automate):

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

## Review template (compat)

Compat package, looks identical to the existing rust-$crate. APPROVED

Comment 4 Fedora Admin user for bugzilla script actions 2025-03-04 04:48:33 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-freedesktop-icons


Note You need to log in before you can comment on or make changes to this bug.