Bug 2347151

Summary: use entire disk by default seems risky
Product: [Fedora] Fedora Reporter: Chris Murphy <bugzilla>
Component: anaconda-webuiAssignee: Katerina Koukiou <kkoukiou>
Status: CLOSED ERRATA QA Contact:
Severity: medium Docs Contact:
Priority: unspecified    
Version: 42CC: anaconda-maint, jkonecny, kkoukiou, lbrabec, mkolman, rvykydal, w
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard: AcceptedFreezeException
Fixed In Version: anaconda-webui-27-1.fc42 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-03-19 00:17:15 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2231339, 2291264    
Attachments:
Description Flags
screenshot
none
program.log
none
storage.log none

Description Chris Murphy 2025-02-23 00:55:27 UTC 
The installer defaults to "Use entire disk: remove all partitions" option.

This is much riskier than "Share disk with other operating system: keep current disk layout"

This is not a per se bug, but it does seem like taking excessive risk on behalf of the user.

Reproducible: Always

Used Fedora-Workstation-Live-42-20250215.n.0.x86_64.iso which contains anaconda 42.24-1.fc42

Steps to Reproduce:
1. Existing OS present
2. Boot install media and launch the installer

Actual Results:  
"Use entire disk" option is selected by default

Expected Results:  
"Share disk with other operating system(s)" OR "Reinstall Fedora: replace current installation but keep files in home" should be the default.

I think we should, by default, err on the side of caution and thus data preservation rather than total obliteration.
Comment 1 Chris Murphy 2025-02-23 00:56:20 UTC 
Created attachment 2077436 [details]
screenshot
Comment 2 Chris Murphy 2025-02-23 00:57:03 UTC 
Created attachment 2077437 [details]
program.log
Comment 3 Chris Murphy 2025-02-23 00:57:16 UTC 
Created attachment 2077438 [details]
storage.log
Comment 4 Katerina Koukiou 2025-03-06 11:03:39 UTC 
Upstream fix: https://github.com/rhinstaller/anaconda-webui/pull/673
Comment 5 Fedora Blocker Bugs Application 2025-03-10 11:48:32 UTC 
Proposed as a Freeze Exception for 42-beta by Fedora user kkoukiou using the blocker tracking app because:

 The Web UI installer defaults to "Use entire disk: remove all partitions" option.
It would be safer and generate better user experience if we select safer default scenarios, depending on the existing disk partitioning.
Comment 6 Lukas Brabec 2025-03-10 18:06:12 UTC 
Discussed during the 2025-03-10 blocker review meeting: [1]

!agreed 2347151 - Accepted as a Beta Freeze Exception - This seems very low risk, and the new default to make a destructive action a deliberate choice makes sense to us.

[1] https://meetbot.fedoraproject.org/blocker-review_matrix_fedoraproject-org/2025-03-10/f42-blocker-review.2025-03-10-16.01.log.html
Comment 7 Fedora Update System 2025-03-14 16:56:55 UTC 
FEDORA-2025-57c36dc467 (anaconda-42.27.4-1.fc42 and anaconda-webui-27-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-57c36dc467
Comment 8 Fedora Update System 2025-03-15 03:34:49 UTC 
FEDORA-2025-57c36dc467 has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-57c36dc467`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-57c36dc467

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 9 Fedora Update System 2025-03-19 00:17:15 UTC 
FEDORA-2025-57c36dc467 (anaconda-42.27.4-1.fc42 and anaconda-webui-27-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.