Bug 234835
| Summary: | Review Request: fgfs-Atlas - Flightgear map tools | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabrice Bellet <fabrice> |
| Component: | Package Review | Assignee: | Jochen Schmitt <jochen> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | hdegoede |
| Target Milestone: | --- | Flags: | jochen:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-04-08 20:20:26 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Fabrice Bellet
2007-04-02 14:23:33 UTC
Good: + Naming ok. + Local build works fine. + Rpmlint is quite on source rpm. + Rpmlint is quite on binary rpm. + Rpmlint ok on debuginfo package. Bad: - Naming ok. - Duplicate BRs Duplicate BuildRequires: plib-devel (by SimGear-devel), libjpeg-devel (by SimGear-devel) Jochen, can you sponsor? Because Fabrice needs a sponsor. If not I can sponsor him, and as an exception to the normal sponsor procedure I would be very happy to see you do the review, as I'm _really_ busy with all kinda Fedora / Linux stuff ATM. I removed the duplicate BuildRequires. Should I rename the package to something better ? There's already an "atlas" (lowercase A) package in Fedora, for http://math-atlas.sourceforge.net/ so I think we should avoid the name "Atlas" alone. Alternative name can be FlightGear-Atlas that clearly shows the relation with the FlightGear project. I chose fgfs-Atlas, because the upstream big all-in-one data tarball of FlightGear is called fgfs-base (BZ#234831), and Atlas primarily works with the scenery files of this tarball. New SPEC: http://fr2.rpmfind.net/pub/bellet/review/fgfs-Atlas.spec New SRPM: http://fr2.rpmfind.net/pub/bellet/review/fgfs-Atlas-0.3.1-3.fc6.src.rpm On my mind flygear-atlas sound better. But then you should rename your other package in flygear-base. (In reply to comment #4) > On my mind flygear-atlas sound better. But then you should rename your other > package in flygear-base. Notice that fgfs-base ic actually called fgfs-base by upstream, so that should not be renamed. As for a name for this. I think that fgfs-atlas, following the base package isn't such a bad idea. good: + Naming ok. + Tar ball matches with upstream. + License ok. + Package contains verbain copy of the license text *** APPROVED *** Jochen, you haven't answered my question yet, can (and will) you sponsor Fabrice, or shall I? Jochen, Will you also review FlightGear itself? Also you still haven't answered my question yet, can (and will) you sponsor Fabrice, or shall I? Fabrice do you want to import these 2 now, or do you want to wait till FlightGear itself is also reviewed? Hans, Yes, I can import fgfs-base and fgfs-Atlas now, and build them. okay, I'll sponsor you then. Go request cvs-extras group membership in the account system, then I can sponsor you. Once sponsored, configure your system for CVS access as described on the wiki and then import and build them. Jochen, that still leaves the question open of reviewing FlightGear itself, any chance you could do that? New Package CVS Request ======================= Package Name: fgfs-Atlas Short Description: Flightgear map tools Owners: fabrice Branches: FC-6 InitialCC: fgfs-Atlas has been successfully build. Thanks for the review. New Package CVS Request ======================= Package Name: FlightGear-Atlas Short Description: Flightgear map tools Owners: fabrice Branches: InitialCC: I'd like to rename this package. The data tarball for FlightGear has been renamed to FlightGear-data recently. So I'll take this opportunity to unify the name of this other package too. With this renaming, all FlightGear related packages will have the same prefix. The upstream name of this package is 'Atlas' (http://atlas.sourceforge.net/), and another unrelated package with this name already exists in the packagedb (atlas for http://math-atlas.sourceforge.net/). So this is why this move doesn't reflect an upstream project modification in this case. request grouped with bz #234831 |