Bug 234857 (Geography-Countries)
| Summary: | Review Request: perl-Geography-Countries - 2-letter, 3-letter, and numerical codes for countries | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <tcallawa> |
| Component: | Package Review | Assignee: | Chris Weyl <cweyl> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | Flags: | cweyl:
fedora-review+
jwboyer: fedora-cvs+ |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-04-04 21:59:13 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 234858 | ||
|
Description
Tom "spot" Callaway
2007-04-02 16:58:17 UTC
+ source files match upstream: 693426ab59ce3d51fcd48dfe3b402107 Geography-Countries-1.4.tar.gz 693426ab59ce3d51fcd48dfe3b402107 ../Geography-Countries-1.4.tar.gz + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. + license field matches the actual license. + license is open source-compatible. License text not included upstream. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package installs properly O no debuginfo package -- noarch + rpmlint is silent. + final provides and requires are sane: ** perl-Geography-Countries-1.4-1.fc6.noarch.rpm == rpmlint == provides perl(Geography::Countries) perl-Geography-Countries = 1.4-1.fc6 == requires perl(:MODULE_COMPAT_5.8.8) perl(Exporter) perl(constant) perl(strict) perl(vars) + %check is present and all tests pass + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no scriptlets present. + code, not content. + documentation is small, so no -docs subpackage is necessary. + %docs are not necessary for the proper functioning of the package. + no headers. + no pkgconfig files. + no libtool .la droppings. + not a GUI app. APPROVED New Package CVS Request ======================= Package Name: perl-Geography-Countries Short Description: 2-letter, 3-letter, and numerical codes for countries Owners: tcallawa Branches: FC-5 FC-6 InitialCC: fedora-perl-devel-list Built. |