Red Hat Bugzilla – Bug 234858
Review Request: perl-User-Identity - Maintains info about a physical person
Last modified: 2007-11-30 17:12:00 EST
Spec URL: http://www.auroralinux.org/people/spot/review/perl-User-Identity.spec
SRPM URL: http://www.auroralinux.org/people/spot/review/perl-User-Identity-0.91-1.src.rpm
A modules designed to store and maintain a set of informational objects which
are related to one user.
Note: BuildRequires: perl-Geography-Countries (234587)
Sanity check: should this bug really be blocked by bug 234587: "VFS: Busy
inodes at umount on NFSv4 filesystem"?
Not really. Thanks for the catch. :)
+ source files match upstream:
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible. License text not included upstream.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package installs properly
+ no debuginfo package -- noarch
+ rpmlint is silent.
+ final provides and requires are sane:
perl(Mail::Identity) = 0.91
perl(User::Identity) = 0.91
perl(User::Identity::Archive) = 0.91
perl(User::Identity::Archive::Plain) = 0.91
perl(User::Identity::Collection) = 0.91
perl(User::Identity::Collection::Emails) = 0.91
perl(User::Identity::Collection::Locations) = 0.91
perl(User::Identity::Collection::Systems) = 0.91
perl(User::Identity::Collection::Users) = 0.91
perl(User::Identity::Item) = 0.91
perl(User::Identity::Location) = 0.91
perl(User::Identity::System) = 0.91
perl-User-Identity = 0.91-1.fc6
+ %check is present and all tests pass:
All tests successful.
Files=3, Tests=114, 0 wallclock secs ( 0.19 cusr + 0.06 csys = 0.25 CPU)
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.
+ not a GUI app.
New Package CVS Request
Package Name: perl-User-Identity
Short Description: Maintains info about a physical person
Branches: FC-5 FC-6