Bug 2351026
| Summary: | UI partly in English when 100% translated | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rafael Fontenelle <rafaelff> |
| Component: | anaconda-webui | Assignee: | Katerina Koukiou <kkoukiou> |
| Status: | CLOSED ERRATA | QA Contact: | |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 42 | CC: | awilliam, geraldo.simiao.kutz, jkonecny, kkoukiou, kparal, mkolman, robatino, rvykydal |
| Target Milestone: | --- | Keywords: | Reopened, Translation |
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | AcceptedBlocker | ||
| Fixed In Version: | anaconda-webui-28-1.fc43 anaconda-webui-30-1.fc42 | Doc Type: | --- |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2025-03-28 00:19:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2291265 | ||
| Attachments: | |||
|
Description
Rafael Fontenelle
2025-03-10 03:38:06 UTC
Created attachment 2079504 [details]
Zip file containing English texts that should be translated
Please see attached the screenshots showing the issue explained in the previous message.
Proposed as a Blocker for 42-final by Fedora user geraldosimiao using the blocker tracking app because: Anaconda webui has UI partly in English even when 100% translated. This affects the criterion "The installer must correctly display all sufficiently complete translations available for use." https://fedoraproject.org/wiki/Fedora_42_Final_Release_Criteria#Installer_translations Upstream fix: https://github.com/rhinstaller/anaconda-webui/pull/703 Unfortunatelly this issue was putting incomplete strings into Weblate. I fixed the issue upstream, but the new strings need to get to weblate, get translated and pulled back in our project. This is now long time after string freeze, but as this was proposed as a blocker, I will proceed with updating the Weblate. Hey, Katerina. Thanks for the PR. Is there a way to keep line short and yet allowing gettext extracting the whole string? I mean, if not I'm already glad to have this fixed, but it is unfortunate to have such a huge line. I also would like to remind that the PR #703 fixes the first part of this bug. I mentioned some strings that are translated with the whole source string, but still are not shown translated in the UI. +5 in https://pagure.io/fedora-qa/blocker-review/issue/1796 , marking accepted. Latest translations were pulled: https://github.com/rhinstaller/anaconda-webui/pull/709 FEDORA-2025-9514d70fb8 (anaconda-webui-28-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-9514d70fb8 FEDORA-2025-9514d70fb8 (anaconda-webui-28-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report. Reopening for F42 tracking. We're waiting for this to land: https://bodhi.fedoraproject.org/updates/FEDORA-2025-a50e6b787b With Fedora-Workstation-Live-42-20250323.n.0.x86_64.iso I still strings untranslated, even though they're translated in the source code. For example "Use entire disk" shows up in English, while it is translated in pt_BR.po [1]. [1] https://github.com/rhinstaller/anaconda-webui/blob/279ff8fd8e81f3b41977776a624bc3c0835f63c9/po/pt_BR.po FEDORA-2025-63711d039a (anaconda-42.27.7-1.fc42 and anaconda-webui-29-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-63711d039a Slightly off-topic, but how does anaconda-webui use Cockpit translations? Is it from a specified Cockpit release? We're (pt_BR translators) are seeing some strings in English that seem to belong Cockpit, and they were incorporated a few dasy ago but only today released (version 336). So I'm trying to understand exactly how it works for anaconda-webui. FEDORA-2025-63711d039a has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-63711d039a` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-63711d039a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. Hi Rafael, when interacting with the Web UI, you will encounter translated strings from the following packages: anaconda-webui [1] anaconda [2] cockpit [3] blivet [4] The Anaconda Web UI integrates cockpit-storage, the Cockpit plugin that manages storage. This is the interface you see when clicking the "Modify Storage" button in the top header dropdown. The UI in that view comes from a separate package, and its translations are maintained within the corresponding RPM. Similarly, some backend responses or error messages displayed in the Web UI originate from the Anaconda backend or Blivet, and their translations are handled within their respective packages. I hope this clarifies your question! [1] https://translate.fedoraproject.org/projects/anaconda-webui/ [2] https://translate.fedoraproject.org/projects/anaconda/ [3] https://translate.fedoraproject.org/projects/cockpit/ [4] https://translate.fedoraproject.org/projects/blivet/ With https://bodhi.fedoraproject.org/updates/FEDORA-2025-f696bd8401 (stable) https://bodhi.fedoraproject.org/updates/FEDORA-2025-63711d039a (testing) I can see anaconda strings translated to pt_BR. So I believe we can close this bug once the latter update is also pushed stable. Regard closing, I agree. The untranslated strings we have are from other projects. Thanks Kamil and Rafael, I think if we close this ticket now, we risk not getting the last cockpit translations to the final build. What do you think? Because AFAIK there will be no more anaconda or cockpit builds after this one prior to the final release. it would be clearest to open a new bug for that, if necessary. Just for info: we just ended the translations of the cockpit strings that get into anaconda-webui FEDORA-2025-63711d039a has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-63711d039a` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-63711d039a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. Katerina, just to get clarification on a specific topic: "The UI in that view comes from a separate package, and its translations are maintained within the corresponding RPM." Does anaconda-webui uses cockpit's (et al.) translations at the anaconda-webui's build time or runtime? Just trying to understand if updating cockpit translations requires a new build from anaconda-webui to make use of all translations. Created attachment 2082037 [details]
print from strings untranslated at UI that are already translated at weblate for more than a week
I retested anaconda-webui-29-1.fc42 and saw these strings in english, but checked weblate for them and confirmed the're from webui package but still without translations at the UI even when they're already translated at weblate for more than a week.
(In reply to Rafael Fontenelle from comment #5) > I also would like to remind that the PR #703 fixes the first part of this > bug. I mentioned some strings that are translated with the whole source > string, but still are not shown translated in the UI. I see the strings I mentioned were already noticed by Rafael. they're still not pulled from weblate. Indeed, I missed some strings. https://github.com/rhinstaller/anaconda-webui/pull/731 The above PR should fix the remaining strings shown in the attachment. Created attachment 2082111 [details]
last version of webui succesfully used the strings Rafael first noted
anaconda-webui-30-1.fc42
FEDORA-2025-63711d039a (anaconda-42.27.9-1.fc42 and anaconda-webui-30-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. Excellent, the last anaconda-webui update (anaconda-webui-31-1.fc42 https://bodhi.fedoraproject.org/updates/FEDORA-2025-900bb2b163) together with the cockpit one (cockpit-336.2-1.fc42 https://bodhi.fedoraproject.org/updates/FEDORA-2025-746939659d) fixed all the translation strings problems we have previously found. Thank you very much for all people involved into this, you're all awesome!!!! |