Bug 2351026 - UI partly in English when 100% translated
Summary: UI partly in English when 100% translated
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda-webui
Version: 42
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Katerina Koukiou
QA Contact:
URL:
Whiteboard: AcceptedBlocker
Depends On:
Blocks: F42FinalBlocker
TreeView+ depends on / blocked
 
Reported: 2025-03-10 03:38 UTC by Rafael Fontenelle
Modified: 2025-03-29 02:42 UTC (History)
8 users (show)

Fixed In Version: anaconda-webui-28-1.fc43 anaconda-webui-30-1.fc42
Clone Of:
Environment:
Last Closed: 2025-03-28 00:19:10 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Zip file containing English texts that should be translated (165.21 KB, application/zip)
2025-03-10 03:49 UTC, Rafael Fontenelle
no flags Details
print from strings untranslated at UI that are already translated at weblate for more than a week (59.75 KB, image/jpeg)
2025-03-26 03:02 UTC, Geraldo Simião
no flags Details
last version of webui succesfully used the strings Rafael first noted (69.72 KB, image/jpeg)
2025-03-26 19:31 UTC, Geraldo Simião
no flags Details

Description Rafael Fontenelle 2025-03-10 03:38:06 UTC
anaconda-webui is 100% translated for Brazilian Portuguese and we're seeing strings that were translated about a year ago (and available in the pt_BR.po) in English in the latest Fedora 42 beta 1.2 ISO (https://dl.fedoraproject.org/pub/alt/stage/42_Beta-1.2/).

I'm going to split this in two situations I found.

------

1. First is: strings concatenated in the source file, but the translation string extraction is extracting only the first part.

Since only the first part of the whole string is extracted, and the translators only translate that first part, the translation doesn't match the existing string when showing it in the resulting UI.

We've spotted this in the following strings and source files:


File: src/components/storage/ReclaimSpaceModal.jsx
String:
<Text>{
    _(
        "Removing a filesystem will permanently delete all of the data it contains. " +
        "Resizing a partition can free up unused space, but is not risk-free. " +
        "Be sure to have backups of anything important before reclaiming space."
    )
}
</Text>

File: src/components/storage/ReclaimSpaceModal.jsx
String:
                {cockpit.format(_(
                    "Reboot into Windows to resize BitLocker-encrypted partitions. " +
                    "Make at least $0 of free space available for installation."
                ), cockpit.format_bytes(requiredSize))}

File: src/components/storage/scenarios/EraseAll.jsx
String:
        availability.hint = cockpit.format(_(
            "The installation needs $1 of disk space; " +
            "however, the capacity of the selected disks is only $0."
        ), cockpit.format_bytes(diskTotalSpace), cockpit.format_bytes(requiredSize));

File: src/components/storage/CockpitStorageIntegration.jsx
String:
                <Text>
                    {_("The storage editor lets you resize, delete, and create partitions. " +
                        "It can set up LVM and much more. " +
                        "It is meant to be used as an advanced utility and not intended to be used in a typical installation.")}
                </Text>

File: src/components/storage/CockpitStorageIntegration.jsx
String:
                message: cockpit.format(
                    _(
                        "Invalid RAID configuration detected.\n" +
                        "If your RAID array is created directly on top of disks, a partition table must be created on the array.\n" +
                        "If your RAID array is created on top of partitions, it must contain a single filesystem or format (e.g., LVM PV). " +
                        "Any existing partitions on this array will be ignored."
                    )

------

The second is: strings look correct, are translated and incorporated to the source code, but not shown translated in the UI.

For Brazilian Portuguese, they are translated for more than a year and I've double-checked the translation in the anaconda-webui package built (anaconda-webui-26-1.fc42.noarch.rpm).

We've spotted this in the following strings (just string, no code) and source files and lines:


#: src/components/storage/HelpAutopartOptions.jsx:5
Remove all partitions on the selected devices, including existing operating systems.

#: src/components/storage/scenarios/EraseAll.jsx:53
"Use entire disk"

#: src/components/storage/scenarios/UseConfiguredStorage.jsx:96
Use configured storage

#: src/components/installation/InstallationProgress.jsx:58
Software installation: Storage configuration complete. The software is now being installed onto your device

#: src/components/installation/InstallationProgress.jsx:65
System configuration

#: src/components/installation/InstallationProgress.jsx:60
Software installation

#: src/components/installation/InstallationProgress.jsx:70
Finalization

#: src/components/storage/scenarios/UseFreeSpace.jsx:81
Share disk with other operating system

#: src/components/storage/HelpAutopartOptions.jsx:7
Keep current disk layout and use available space, to dual-boot with another OS;


#: src/components/storage/MountPointMapping.jsx:622
#: src/components/storage/scenarios/MountPointMapping.jsx:69
Mount point assignment

#: src/components/storage/HelpAutopartOptions.jsx:9
Assign partitions to mount points. Useful for pre-configured custom layouts.

#: src/components/storage/scenarios/UseConfiguredStorage.jsx:96
Use configured storage

#: src/components/storage/HelpAutopartOptions.jsx:13
Storage is based on the configuration from 'Modify storage'

Reproducible: Always

Steps to Reproduce:
1. Run Anaconda WebUI installer with pt_BR language code
Actual Results:  
Partly translated WebUI  (ignore incomplete strings from cockpit, we're working that)

Expected Results:  
To see translated the strings that we already translated and are part of the UI.

Comment 1 Rafael Fontenelle 2025-03-10 03:49:59 UTC
Created attachment 2079504 [details]
Zip file containing English texts that should be translated

Please see attached the screenshots showing the issue explained in the previous message.

Comment 2 Fedora Blocker Bugs Application 2025-03-16 02:54:10 UTC
Proposed as a Blocker for 42-final by Fedora user geraldosimiao using the blocker tracking app because:

 Anaconda webui has UI partly in English even when 100% translated. This affects the criterion "The installer must correctly display all sufficiently complete translations available for use." https://fedoraproject.org/wiki/Fedora_42_Final_Release_Criteria#Installer_translations

Comment 3 Katerina Koukiou 2025-03-17 11:23:28 UTC
Upstream fix: https://github.com/rhinstaller/anaconda-webui/pull/703

Unfortunatelly this issue was putting incomplete strings into Weblate. I fixed the issue upstream, but the new strings need to get to weblate, get translated and pulled back in our project. This is now long time after string freeze, but as this was proposed as a blocker, I will proceed with updating the Weblate.

Comment 4 Rafael Fontenelle 2025-03-17 11:40:45 UTC
Hey, Katerina. Thanks for the PR. Is there a way to keep line short and yet allowing gettext extracting the whole string? I mean, if not I'm already glad to have this fixed, but it is unfortunate to have such a huge line.

Comment 5 Rafael Fontenelle 2025-03-17 12:03:35 UTC
I also would like to remind that the PR #703 fixes the first part of this bug. I mentioned some strings that are translated with the whole source string, but still are not shown translated in the UI.

Comment 6 Adam Williamson 2025-03-17 15:41:28 UTC
+5 in https://pagure.io/fedora-qa/blocker-review/issue/1796 , marking accepted.

Comment 7 Katerina Koukiou 2025-03-19 11:04:20 UTC
Latest translations were pulled: https://github.com/rhinstaller/anaconda-webui/pull/709

Comment 8 Fedora Update System 2025-03-20 13:39:45 UTC
FEDORA-2025-9514d70fb8 (anaconda-webui-28-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-9514d70fb8

Comment 9 Fedora Update System 2025-03-20 14:56:55 UTC
FEDORA-2025-9514d70fb8 (anaconda-webui-28-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Kamil Páral 2025-03-21 09:11:02 UTC
Reopening for F42 tracking.

Comment 11 Kamil Páral 2025-03-21 09:44:50 UTC
We're waiting for this to land:
https://bodhi.fedoraproject.org/updates/FEDORA-2025-a50e6b787b

Comment 12 Kamil Páral 2025-03-24 07:07:02 UTC
With Fedora-Workstation-Live-42-20250323.n.0.x86_64.iso I still strings untranslated, even though they're translated in the source code. For example "Use entire disk" shows up in English, while it is translated in pt_BR.po [1].

[1] https://github.com/rhinstaller/anaconda-webui/blob/279ff8fd8e81f3b41977776a624bc3c0835f63c9/po/pt_BR.po

Comment 13 Fedora Update System 2025-03-24 16:34:38 UTC
FEDORA-2025-63711d039a (anaconda-42.27.7-1.fc42 and anaconda-webui-29-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-63711d039a

Comment 14 Rafael Fontenelle 2025-03-24 18:28:55 UTC
Slightly off-topic, but how does anaconda-webui use Cockpit translations? Is it from a specified Cockpit release?

We're (pt_BR translators) are seeing some strings in English that seem to belong Cockpit, and they were incorporated a few dasy ago but only today released (version 336). So I'm trying to understand exactly how it works for anaconda-webui.

Comment 15 Fedora Update System 2025-03-25 02:00:32 UTC
FEDORA-2025-63711d039a has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-63711d039a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-63711d039a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Katerina Koukiou 2025-03-25 07:16:36 UTC
Hi Rafael, when interacting with the Web UI, you will encounter translated strings from the following packages:

anaconda-webui [1]
anaconda [2]
cockpit [3]
blivet [4]

The Anaconda Web UI integrates cockpit-storage, the Cockpit plugin that manages storage. This is the interface you see when clicking the "Modify Storage" button in the top header dropdown.

The UI in that view comes from a separate package, and its translations are maintained within the corresponding RPM.

Similarly, some backend responses or error messages displayed in the Web UI originate from the Anaconda backend or Blivet, and their translations are handled within their respective packages.

I hope this clarifies your question!

[1] https://translate.fedoraproject.org/projects/anaconda-webui/
[2] https://translate.fedoraproject.org/projects/anaconda/
[3] https://translate.fedoraproject.org/projects/cockpit/
[4] https://translate.fedoraproject.org/projects/blivet/

Comment 17 Kamil Páral 2025-03-25 08:45:57 UTC
With
https://bodhi.fedoraproject.org/updates/FEDORA-2025-f696bd8401 (stable)
https://bodhi.fedoraproject.org/updates/FEDORA-2025-63711d039a (testing)

I can see anaconda strings translated to pt_BR. So I believe we can close this bug once the latter update is also pushed stable.

Comment 18 Rafael Fontenelle 2025-03-25 12:08:15 UTC
Regard closing, I agree. The untranslated strings we have are from other projects. Thanks

Comment 19 Geraldo Simião 2025-03-26 01:26:25 UTC
Kamil and Rafael, I think if we close this ticket now, we risk not getting the last cockpit translations to the final build. What do you think? Because AFAIK there will be no more anaconda or cockpit builds after this one prior to the final release.

Comment 20 Adam Williamson 2025-03-26 01:28:57 UTC
it would be clearest to open a new bug for that, if necessary.

Comment 21 Geraldo Simião 2025-03-26 01:30:12 UTC
Just for info: we just ended the translations of the cockpit strings that get into anaconda-webui

Comment 22 Fedora Update System 2025-03-26 01:31:29 UTC
FEDORA-2025-63711d039a has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-63711d039a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-63711d039a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 23 Rafael Fontenelle 2025-03-26 02:10:04 UTC
Katerina, just to get clarification on a specific topic:

"The UI in that view comes from a separate package, and its translations are maintained within the corresponding RPM."

Does anaconda-webui uses cockpit's (et al.) translations at the anaconda-webui's build time or runtime? Just trying to understand if updating cockpit translations requires a new build from anaconda-webui to make use of all translations.

Comment 24 Geraldo Simião 2025-03-26 03:02:51 UTC
Created attachment 2082037 [details]
print from strings untranslated at UI that are already translated at weblate for more than a week

I retested anaconda-webui-29-1.fc42 and saw these strings in english, but checked weblate for them and confirmed the're from webui package but still without translations at the UI even when they're already translated at weblate for more than a week.

Comment 25 Geraldo Simião 2025-03-26 03:09:32 UTC
(In reply to Rafael Fontenelle from comment #5)
> I also would like to remind that the PR #703 fixes the first part of this
> bug. I mentioned some strings that are translated with the whole source
> string, but still are not shown translated in the UI.

I see the strings I mentioned were already noticed by Rafael. they're still not pulled from weblate.

Comment 26 Katerina Koukiou 2025-03-26 07:35:09 UTC
Indeed, I missed some strings. https://github.com/rhinstaller/anaconda-webui/pull/731
The above PR should fix the remaining strings shown in the attachment.

Comment 27 Geraldo Simião 2025-03-26 19:31:56 UTC
Created attachment 2082111 [details]
last version of webui succesfully used the strings Rafael first noted

anaconda-webui-30-1.fc42

Comment 28 Fedora Update System 2025-03-28 00:19:10 UTC
FEDORA-2025-63711d039a (anaconda-42.27.9-1.fc42 and anaconda-webui-30-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 29 Geraldo Simião 2025-03-29 02:42:20 UTC
Excellent, the last anaconda-webui update (anaconda-webui-31-1.fc42 https://bodhi.fedoraproject.org/updates/FEDORA-2025-900bb2b163) together with the cockpit one (cockpit-336.2-1.fc42 https://bodhi.fedoraproject.org/updates/FEDORA-2025-746939659d) fixed all the translation strings problems we have previously found. 

Thank you very much for all people involved into this, you're all awesome!!!!


Note You need to log in before you can comment on or make changes to this bug.