Bug 2351807

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8760780
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2351807-x-cmd/fedora-rawhide-x86_64/08760780-x-cmd/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.

(In reply to Package Review from comment #2)
> This is an automatic check from review-stats script.
> 
> This review request ticket hasn't been updated for some time. We're sorry
> it is taking so long. If you're still interested in packaging this software
> into Fedora repositories, please respond to this comment clearing the
> NEEDINFO flag.
> 
> You may want to update the specfile and the src.rpm to the latest version
> available and to propose a review swap on Fedora devel mailing list to
> increase
> chances to have your package reviewed. If this is your first package and you
> need a sponsor, you may want to post some informal reviews. Read more at
> https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.
> 
> Without any reply, this request will shortly be considered abandoned
> and will be closed.
> Thank you for your patience.

Thanks for the reminder. We are still very much interested in packaging this software into Fedora.

The package has been updated to the latest upstream version. The new spec file and src.rpm reflect this update. Please clear the NEEDINFO flag and let us know if any further changes or reviews are 
required.

We will also look into proposing a review swap on the Fedora devel mailing list as suggested. Thank you for your patience and continued support.

> Version:        v0.9.9
You should use "0.9.9" here. Also, 0.9.15 is now available.

> Source0:        https://raw.githubusercontent.com/%{name}/release/main/dist/%{version}/allinone.tgz
This gives HTTP 404.

> %install
> rm -rf %{buildroot}
Don't.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections

> %files
> %{_prefix}/share/x-cmd/v/%{_pkgsum}/
> %{_prefix}/share/x-cmd/v/latest
You should use "%{_datadir}" instead of "%{_prefix}/share".