Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://download.copr.fedorainfracloud.org/results/x-cmd/x-cmd/fedora-rawhide-x86_64/10652781-x-cmd/x-cmd.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/x-cmd/x-cmd/fedora-rawhide-x86_64/10652781-x-cmd/x-cmd-v0.9.9-1.fc45.src.rpm Description: x-cmd is a toolset implemented using POSIX shell and AWK. It’s very lightweight and helps quickly set up necessary tools and environment in a fresh system. It has a small footprint yet offers many interesting features. Here’s a milestone demo: [https://x-cmd.com/](https://x-cmd.com/) Fedora Account System Username: x-cmd
Copr build: https://copr.fedorainfracloud.org/coprs/build/8760780 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2351807-x-cmd/fedora-rawhide-x86_64/08760780-x-cmd/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.
(In reply to Package Review from comment #2) > This is an automatic check from review-stats script. > > This review request ticket hasn't been updated for some time. We're sorry > it is taking so long. If you're still interested in packaging this software > into Fedora repositories, please respond to this comment clearing the > NEEDINFO flag. > > You may want to update the specfile and the src.rpm to the latest version > available and to propose a review swap on Fedora devel mailing list to > increase > chances to have your package reviewed. If this is your first package and you > need a sponsor, you may want to post some informal reviews. Read more at > https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. > > Without any reply, this request will shortly be considered abandoned > and will be closed. > Thank you for your patience. Thanks for the reminder. We are still very much interested in packaging this software into Fedora. The package has been updated to the latest upstream version. The new spec file and src.rpm reflect this update. Please clear the NEEDINFO flag and let us know if any further changes or reviews are required. We will also look into proposing a review swap on the Fedora devel mailing list as suggested. Thank you for your patience and continued support.
> Version: v0.9.9 You should use "0.9.9" here. Also, 0.9.15 is now available. > Source0: https://raw.githubusercontent.com/%{name}/release/main/dist/%{version}/allinone.tgz This gives HTTP 404. > %install > rm -rf %{buildroot} Don't. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections > %files > %{_prefix}/share/x-cmd/v/%{_pkgsum}/ > %{_prefix}/share/x-cmd/v/latest You should use "%{_datadir}" instead of "%{_prefix}/share".
(In reply to Artur Frenszek-Iwicki from comment #5) Hi Artur, Thank you for the detailed review and feedback! I have updated the spec file and SRPM to address all the issues: - Removed the leading `v` and updated the package to the latest version (`0.10.0`). - Removed `rm -rf %{buildroot}` from the `%install` section. - Replaced `%{_prefix}/share` with `%{_datadir}`. Updated Files: Spec URL: https://download.copr.fedorainfracloud.org/results/x-cmd/x-cmd/fedora-rawhide-x86_64/10797699-x-cmd/x-cmd.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/x-cmd/x-cmd/fedora-rawhide-x86_64/10797699-x-cmd/x-cmd-0.10.0-1.fc45.src.rpm Thanks again for your time!
Created attachment 2153142 [details] The .spec file difference from Copr build 8760780 to 10799086
Copr build: https://copr.fedorainfracloud.org/coprs/build/10799086 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2351807-x-cmd/fedora-rawhide-x86_64/10799086-x-cmd/fedora-review/review.txt Found issues: - License file COPYING.md is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.