Bug 2352760 (rust-usbredirparser-sys)

Summary: Review Request: rust-usbredirparser-sys - FFI bindings for usbredirparser
Product: [Fedora] Fedora Reporter: Marc-Andre Lureau <marcandre.lureau>
Component: Package ReviewAssignee: Cole Robinson <crobinso>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: crobinso, package-review
Target Milestone: ---Flags: crobinso: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/usbredirparser-sys
Whiteboard:
Fixed In Version: Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-03-24 08:11:58 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2352762    
Attachments:
Description Flags
The .spec file difference from Copr build 8771476 to 8798854 none

Comment 1 Fedora Review Service 2025-03-16 07:52:50 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8771476
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2352760-rust-usbredirparser-sys/fedora-rawhide-x86_64/08771476-rust-usbredirparser-sys/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Cole Robinson 2025-03-19 19:22:09 UTC
scratch build failed on i686: https://koji.fedoraproject.org/koji/taskinfo?taskID=130495079

Comment 3 Marc-Andre Lureau 2025-03-19 20:19:34 UTC
Can we exclude i686?

Comment 4 Cole Robinson 2025-03-20 14:47:17 UTC
Yeah dropping i686 is fine IMO: https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval

Comment 6 Fedora Review Service 2025-03-20 18:29:57 UTC
Created attachment 2081119 [details]
The .spec file difference from Copr build 8771476 to 8798854

Comment 7 Fedora Review Service 2025-03-20 18:29:59 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8798854
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2352760-rust-usbredirparser-sys/fedora-rawhide-x86_64/08798854-rust-usbredirparser-sys/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 8 Cole Robinson 2025-03-23 19:32:07 UTC
+ spec matches rust2rpm output (plus the i686 exclusion)
+ builds on rawhide
+ installs on rawhide
+ content looks fine

setting fedora-review+

Comment 9 Fedora Admin user for bugzilla script actions 2025-03-24 07:43:31 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-usbredirparser-sys

Comment 10 Fedora Update System 2025-03-24 08:09:40 UTC
FEDORA-2025-a440db3bcc (rust-usbredirparser-sys-0.4.0-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-a440db3bcc

Comment 11 Fedora Update System 2025-03-24 08:11:58 UTC
FEDORA-2025-a440db3bcc (rust-usbredirparser-sys-0.4.0-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.