Bug 2352760 (rust-usbredirparser-sys) - Review Request: rust-usbredirparser-sys - FFI bindings for usbredirparser
Summary: Review Request: rust-usbredirparser-sys - FFI bindings for usbredirparser
Keywords:
Status: CLOSED ERRATA
Alias: rust-usbredirparser-sys
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Cole Robinson
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/usbredirpars...
Whiteboard:
Depends On:
Blocks: rust-usbredirparser
TreeView+ depends on / blocked
 
Reported: 2025-03-16 07:47 UTC by Marc-Andre Lureau
Modified: 2025-03-24 08:11 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-03-24 08:11:58 UTC
Type: ---
Embargoed:
crobinso: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 8771476 to 8798854 (388 bytes, patch)
2025-03-20 18:29 UTC, Fedora Review Service
no flags Details | Diff

Comment 1 Fedora Review Service 2025-03-16 07:52:50 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8771476
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2352760-rust-usbredirparser-sys/fedora-rawhide-x86_64/08771476-rust-usbredirparser-sys/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Cole Robinson 2025-03-19 19:22:09 UTC
scratch build failed on i686: https://koji.fedoraproject.org/koji/taskinfo?taskID=130495079

Comment 3 Marc-Andre Lureau 2025-03-19 20:19:34 UTC
Can we exclude i686?

Comment 4 Cole Robinson 2025-03-20 14:47:17 UTC
Yeah dropping i686 is fine IMO: https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval

Comment 6 Fedora Review Service 2025-03-20 18:29:57 UTC
Created attachment 2081119 [details]
The .spec file difference from Copr build 8771476 to 8798854

Comment 7 Fedora Review Service 2025-03-20 18:29:59 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8798854
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2352760-rust-usbredirparser-sys/fedora-rawhide-x86_64/08798854-rust-usbredirparser-sys/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 8 Cole Robinson 2025-03-23 19:32:07 UTC
+ spec matches rust2rpm output (plus the i686 exclusion)
+ builds on rawhide
+ installs on rawhide
+ content looks fine

setting fedora-review+

Comment 9 Fedora Admin user for bugzilla script actions 2025-03-24 07:43:31 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-usbredirparser-sys

Comment 10 Fedora Update System 2025-03-24 08:09:40 UTC
FEDORA-2025-a440db3bcc (rust-usbredirparser-sys-0.4.0-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-a440db3bcc

Comment 11 Fedora Update System 2025-03-24 08:11:58 UTC
FEDORA-2025-a440db3bcc (rust-usbredirparser-sys-0.4.0-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.