Bug 2353284

Summary: Review Request: mactel-boot - Intel Mac boot files
Product: [Fedora] Fedora Reporter: Neal Gompa <ngompa13>
Component: Package ReviewAssignee: Davide Cavalca <davide>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: davide, package-review
Target Milestone: ---Flags: davide: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: http://www.codon.org.uk/~mjg59/mactel-boot/
Whiteboard:
Fixed In Version: Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-03-22 02:40:28 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2347153    

Description Neal Gompa 2025-03-19 00:28:17 UTC
Spec URL: https://ngompa.fedorapeople.org/for-review/mactel-boot.spec
SRPM URL: https://ngompa.fedorapeople.org/for-review/mactel-boot-0.9-34.fc43.src.rpm

Description:
Files for booting Fedora on Intel-based Apple hardware using EFI.

Fedora Account System Username: ngompa

Comment 1 Neal Gompa 2025-03-19 00:29:28 UTC
Note this is an unretirement review request.

Comment 2 Fedora Review Service 2025-03-19 00:32:53 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8790793
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2353284-mactel-boot/fedora-rawhide-x86_64/08790793-mactel-boot/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/mactel-boot
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Davide Cavalca 2025-03-20 04:27:30 UTC
This is generally fine, but I would recommend updating the spec to use modern macros, fixing indentation and dropping the license audit comment. Also on 

> install -D -m 644 SystemVersion.plist $RPM_BUILD_ROOT/boot/efi/System/Library/CoreServices/SystemVersion.plist

please use -p to preserve timestamps, which will help with reproducibility.

None of these are really blockers, so I'm approving as-is, but please fix them on import.

Comment 4 Fedora Update System 2025-03-21 00:45:57 UTC
FEDORA-2025-870a78179f (mactel-boot-0.9-35.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-870a78179f

Comment 5 Fedora Update System 2025-03-22 02:40:28 UTC
FEDORA-2025-870a78179f (mactel-boot-0.9-35.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.