Bug 2353284 - Review Request: mactel-boot - Intel Mac boot files
Summary: Review Request: mactel-boot - Intel Mac boot files
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Davide Cavalca
QA Contact: Fedora Extras Quality Assurance
URL: http://www.codon.org.uk/~mjg59/mactel...
Whiteboard:
Depends On:
Blocks: 2347153
TreeView+ depends on / blocked
 
Reported: 2025-03-19 00:28 UTC by Neal Gompa
Modified: 2025-03-22 02:40 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-03-22 02:40:28 UTC
Type: ---
Embargoed:
davide: fedora-review+


Attachments (Terms of Use)

Description Neal Gompa 2025-03-19 00:28:17 UTC
Spec URL: https://ngompa.fedorapeople.org/for-review/mactel-boot.spec
SRPM URL: https://ngompa.fedorapeople.org/for-review/mactel-boot-0.9-34.fc43.src.rpm

Description:
Files for booting Fedora on Intel-based Apple hardware using EFI.

Fedora Account System Username: ngompa

Comment 1 Neal Gompa 2025-03-19 00:29:28 UTC
Note this is an unretirement review request.

Comment 2 Fedora Review Service 2025-03-19 00:32:53 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8790793
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2353284-mactel-boot/fedora-rawhide-x86_64/08790793-mactel-boot/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/mactel-boot
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Davide Cavalca 2025-03-20 04:27:30 UTC
This is generally fine, but I would recommend updating the spec to use modern macros, fixing indentation and dropping the license audit comment. Also on 

> install -D -m 644 SystemVersion.plist $RPM_BUILD_ROOT/boot/efi/System/Library/CoreServices/SystemVersion.plist

please use -p to preserve timestamps, which will help with reproducibility.

None of these are really blockers, so I'm approving as-is, but please fix them on import.

Comment 4 Fedora Update System 2025-03-21 00:45:57 UTC
FEDORA-2025-870a78179f (mactel-boot-0.9-35.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-870a78179f

Comment 5 Fedora Update System 2025-03-22 02:40:28 UTC
FEDORA-2025-870a78179f (mactel-boot-0.9-35.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.