Bug 2354812
| Summary: | Review Request: thorvg - Lightweight vector-based scenes and animation drawing library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Benson Muite <benson_muite> |
| Component: | Package Review | Assignee: | Simone Caronni <negativo17> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | negativo17, package-review |
| Target Milestone: | --- | Flags: | negativo17:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| URL: | https://www.thorvg.org/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2025-04-09 01:52:35 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Benson Muite
2025-03-25 11:32:37 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8818339 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2354812-thorvg/fedora-rawhide-x86_64/08818339-thorvg/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Update build spec: https://fed500.fedorapeople.org/thorvg.spec srpm: https://fed500.fedorapeople.org/thorvg-0.15.11-1.fc43.src.rpm Some comments: > BuildRequires: libjpeg-turbo-devel > BuildRequires: libpng-devel > BuildRequires: libwebp-devel > BuildRequires: mesa-libGL-devel > BuildRequires: rapidjson-devel > BuildRequires: SDL2-devel > BuildRequires: meson > BuildRequires: ninja-build Meson looks for some of these dependencies using pkgconfig, so for those please update the build requirements to use the pkgconfig format. Example: BuildRequires: pkgconfig(libturbojpeg) BuildRequires: pkgconfig(libpng) BuildRequires: pkgconfig(libwebp) BuildRequires: pkgconfig(sdl2) > # Modifications do not allow for use of packaged rapidjson > # https://github.com/thorvg/thorvg/issues/3358 > Provides: bundled(rapidjson) I think this is just a leftover to remove, as you require rapidjson as BuildRequires and you are also removing src/loaders/lottie/rapidjson in the %prep section. > %global _description %{expand: > [..] > %description %_description You can avoid using the macro, you are calling the block of description just once, it's more readable if you put the description under %description directly. Otherwise looks good. (In reply to Simone Caronni from comment #3) > Some comments: > > > BuildRequires: libjpeg-turbo-devel > > BuildRequires: libpng-devel > > BuildRequires: libwebp-devel > > BuildRequires: mesa-libGL-devel > > BuildRequires: rapidjson-devel > > BuildRequires: SDL2-devel > > BuildRequires: meson > > BuildRequires: ninja-build > > Meson looks for some of these dependencies using pkgconfig, so for those > please update the build requirements to use the pkgconfig format. Example: > > BuildRequires: pkgconfig(libturbojpeg) > BuildRequires: pkgconfig(libpng) > BuildRequires: pkgconfig(libwebp) > BuildRequires: pkgconfig(sdl2) Done. > > > # Modifications do not allow for use of packaged rapidjson > > # https://github.com/thorvg/thorvg/issues/3358 > > Provides: bundled(rapidjson) > > I think this is just a leftover to remove, as you require rapidjson as > BuildRequires and you are also removing src/loaders/lottie/rapidjson in the > %prep section. That package will not build, removing the files was an error. > > > %global _description %{expand: > > [..] > > %description %_description > > You can avoid using the macro, you are calling the block of description just > once, it's more readable if you put the description under %description > directly. > Done. spec: https://fed500.fedorapeople.org/thorvg.spec srpm: https://fed500.fedorapeople.org/thorvg-0.15.11-1.fc43.src.rpm Approved. Thanks for the review. The Pagure repository was created at https://src.fedoraproject.org/rpms/thorvg FEDORA-2025-dd80a234ba (thorvg-0.15.11-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-dd80a234ba FEDORA-2025-433be90aa5 (thorvg-0.15.11-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-433be90aa5 FEDORA-2025-dd80a234ba has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-dd80a234ba \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-dd80a234ba See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-433be90aa5 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-433be90aa5 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-433be90aa5 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-dd80a234ba (thorvg-0.15.11-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-433be90aa5 (thorvg-0.15.11-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. |