spec: https://fed500.fedorapeople.org/thorvg.spec srpm: https://fed500.fedorapeople.org/thorvg-0.15.11-1.fc43.src.rpm description: ThorVG is an open-source graphics library designed for creating vector-based scenes and animations. It combines immense power with remarkable lightweight efficiency, as Thor embodies a dual meaning—symbolizing both thunderous strength and lightning-fast agility. Embracing the philosophy of simpler is better, the ThorVG project provides intuitive, user-friendly interfaces while maintaining a compact footprint and minimal overhead. The following list shows primitives that are supported by ThorVG: - Lines & Shapes: rectangles, circles, and paths with coordinate control - Filling: solid colors, linear & radial gradients, and path clipping - Stroking: stroke width, joins, caps, dash patterns, and trimming - Scene Management: retainable scene graph and object transformations - Composition: various blending and masking - Text: unicode characters with horizontal text layout using scalable fonts (TTF) - Images: SVG, JPG, PNG, WebP, and raw bitmaps - Effects: blur, drop shadow, fill, tint, tritone and color replacement - Animations: Lottie fas: fed500 Reproducible: Always
Copr build: https://copr.fedorainfracloud.org/coprs/build/8818339 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2354812-thorvg/fedora-rawhide-x86_64/08818339-thorvg/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Update build spec: https://fed500.fedorapeople.org/thorvg.spec srpm: https://fed500.fedorapeople.org/thorvg-0.15.11-1.fc43.src.rpm
Some comments: > BuildRequires: libjpeg-turbo-devel > BuildRequires: libpng-devel > BuildRequires: libwebp-devel > BuildRequires: mesa-libGL-devel > BuildRequires: rapidjson-devel > BuildRequires: SDL2-devel > BuildRequires: meson > BuildRequires: ninja-build Meson looks for some of these dependencies using pkgconfig, so for those please update the build requirements to use the pkgconfig format. Example: BuildRequires: pkgconfig(libturbojpeg) BuildRequires: pkgconfig(libpng) BuildRequires: pkgconfig(libwebp) BuildRequires: pkgconfig(sdl2) > # Modifications do not allow for use of packaged rapidjson > # https://github.com/thorvg/thorvg/issues/3358 > Provides: bundled(rapidjson) I think this is just a leftover to remove, as you require rapidjson as BuildRequires and you are also removing src/loaders/lottie/rapidjson in the %prep section. > %global _description %{expand: > [..] > %description %_description You can avoid using the macro, you are calling the block of description just once, it's more readable if you put the description under %description directly. Otherwise looks good.
(In reply to Simone Caronni from comment #3) > Some comments: > > > BuildRequires: libjpeg-turbo-devel > > BuildRequires: libpng-devel > > BuildRequires: libwebp-devel > > BuildRequires: mesa-libGL-devel > > BuildRequires: rapidjson-devel > > BuildRequires: SDL2-devel > > BuildRequires: meson > > BuildRequires: ninja-build > > Meson looks for some of these dependencies using pkgconfig, so for those > please update the build requirements to use the pkgconfig format. Example: > > BuildRequires: pkgconfig(libturbojpeg) > BuildRequires: pkgconfig(libpng) > BuildRequires: pkgconfig(libwebp) > BuildRequires: pkgconfig(sdl2) Done. > > > # Modifications do not allow for use of packaged rapidjson > > # https://github.com/thorvg/thorvg/issues/3358 > > Provides: bundled(rapidjson) > > I think this is just a leftover to remove, as you require rapidjson as > BuildRequires and you are also removing src/loaders/lottie/rapidjson in the > %prep section. That package will not build, removing the files was an error. > > > %global _description %{expand: > > [..] > > %description %_description > > You can avoid using the macro, you are calling the block of description just > once, it's more readable if you put the description under %description > directly. > Done. spec: https://fed500.fedorapeople.org/thorvg.spec srpm: https://fed500.fedorapeople.org/thorvg-0.15.11-1.fc43.src.rpm
Approved.
Thanks for the review.
The Pagure repository was created at https://src.fedoraproject.org/rpms/thorvg
FEDORA-2025-dd80a234ba (thorvg-0.15.11-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-dd80a234ba
FEDORA-2025-433be90aa5 (thorvg-0.15.11-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-433be90aa5
https://release-monitoring.org/project/377440/
FEDORA-2025-dd80a234ba has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-dd80a234ba \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-dd80a234ba See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-433be90aa5 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-433be90aa5 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-433be90aa5 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-dd80a234ba (thorvg-0.15.11-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-433be90aa5 (thorvg-0.15.11-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.