Bug 2355813

Summary:	Review Request: fedora-eln-backgrounds - Fedora ELN default desktop background
Product:	[Fedora] Fedora	Reporter:	Troy Dawson <tdawson>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ngompa13, package-review, yselkowi
Target Milestone:	---	Flags:	ngompa13: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	---
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2025-04-04 15:47:33 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Troy Dawson 2025-03-28 18:35:23 UTC

Spec URL: https://tdawson.fedorapeople.org/review/fedora-eln-backgrounds/fedora-eln-backgrounds.spec
SRPM URL: https://tdawson.fedorapeople.org/review/fedora-eln-backgrounds/fedora-eln-backgrounds-1.0-1.eln147.src.rpm
Description: This package contains desktop backgrounds for the Fedora ELN default theme.
Fedora Account System Username: tdawson

Comment 1 Neal Gompa 2025-03-28 18:51:05 UTC

Taking this review.

Comment 2 Neal Gompa 2025-03-28 18:53:22 UTC

Initial spec review:

> Provides:       system-backgrounds = %{rhel}-%{release}

Does this need to be a versioned provide?

Comment 3 Troy Dawson 2025-03-28 20:52:41 UTC

(In reply to Neal Gompa from comment #2)
> Initial spec review:
> 
> > Provides:       system-backgrounds = %{rhel}-%{release}
> 
> Does this need to be a versioned provide?

Good question.  I don't really know.  I'm ok taking the version off.

Comment 4 Troy Dawson 2025-03-28 21:00:26 UTC

Update Spec and source rpm have an versioned provides of system-backgrounds

Provides:       system-backgrounds

Comment 5 Neal Gompa 2025-03-28 22:04:46 UTC

> %doc


What is this supposed to capture?

Comment 6 Troy Dawson 2025-03-28 22:21:27 UTC

Good question, looks like nothing.  
I'll take it out.

Comment 7 Neal Gompa 2025-03-28 23:07:36 UTC

The license file included is wrong. This is the correct file: https://creativecommons.org/licenses/by-sa/4.0/legalcode.txt

Comment 8 Troy Dawson 2025-03-31 14:41:44 UTC

Updated spec and source rpm:
- Update license file
- Removed %doc from the %files section

Comment 9 Neal Gompa 2025-04-03 20:00:02 UTC

At this point, it looks fine based on the stuff in https://github.com/fedora-eln/backgrounds

* Package builds and installs
* Package licensing is correct and valid license files are installed
* No serious issues from rpmlint

Please conditionalize the "Provides: system-backgrounds" on eln before importing.

I'm not a fan of calling this "fedora-eln-backgrounds" instead of "eln-backgrounds", but I won't hold this up on that.

PACKAGE APPROVED.

Comment 10 Fedora Admin user for bugzilla script actions 2025-04-04 14:41:36 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/fedora-eln-backgrounds

Comment 11 Troy Dawson 2025-04-04 15:47:33 UTC

The main target of this review request is ELN.
We now have a successful ELN build.
https://koji.fedoraproject.org/koji/taskinfo?taskID=131104580