Spec URL: https://tdawson.fedorapeople.org/review/fedora-eln-backgrounds/fedora-eln-backgrounds.spec SRPM URL: https://tdawson.fedorapeople.org/review/fedora-eln-backgrounds/fedora-eln-backgrounds-1.0-1.eln147.src.rpm Description: This package contains desktop backgrounds for the Fedora ELN default theme. Fedora Account System Username: tdawson
Taking this review.
Initial spec review: > Provides: system-backgrounds = %{rhel}-%{release} Does this need to be a versioned provide?
(In reply to Neal Gompa from comment #2) > Initial spec review: > > > Provides: system-backgrounds = %{rhel}-%{release} > > Does this need to be a versioned provide? Good question. I don't really know. I'm ok taking the version off.
Update Spec and source rpm have an versioned provides of system-backgrounds Provides: system-backgrounds
> %doc What is this supposed to capture?
Good question, looks like nothing. I'll take it out.
The license file included is wrong. This is the correct file: https://creativecommons.org/licenses/by-sa/4.0/legalcode.txt
Updated spec and source rpm: - Update license file - Removed %doc from the %files section
At this point, it looks fine based on the stuff in https://github.com/fedora-eln/backgrounds * Package builds and installs * Package licensing is correct and valid license files are installed * No serious issues from rpmlint Please conditionalize the "Provides: system-backgrounds" on eln before importing. I'm not a fan of calling this "fedora-eln-backgrounds" instead of "eln-backgrounds", but I won't hold this up on that. PACKAGE APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/fedora-eln-backgrounds
The main target of this review request is ELN. We now have a successful ELN build. https://koji.fedoraproject.org/koji/taskinfo?taskID=131104580