Bug 2356834 (rust-qapi-qga)

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8848107
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2356834-rust-qapi-qga/fedora-rawhide-x86_64/08848107-rust-qapi-qga/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

One small issue: The Source1 URL is 404, it's missing the git ref part of the URL.

Spec URL: https://raw.githubusercontent.com/elmarco/ironrdp-fedora/refs/heads/master/rust-qapi-qga/rust-qapi-qga.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/elmarco/qemu-rdp/srpm-builds/08876072/rust-qapi-qga-0.13.0-1.src.rpm
Description: QEMU Guest Agent protocol types
Fedora Account System Username: elmarco

Why did you include the GPLv2 license text here too? There are no GPLv2 licensed files in this crate.

Created attachment 2084082 [details]
The .spec file difference from Copr build 8848107 to 8881512

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8881512
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2356834-rust-qapi-qga/fedora-rawhide-x86_64/08881512-rust-qapi-qga/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

(In reply to Fabio Valentini from comment #4)
> Why did you include the GPLv2 license text here too? There are no GPLv2
> licensed files in this crate.

./schema/qga/qapi-schema.json is also from QEMU

Ok, please document this in the spec file then.
This file (in constrast to the other ones where I noticed this) doesn't have a license header with an SPDX identifier.

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
🫤 test suite is run and all unit tests pass (there are no tests)
✅ latest version of the crate is packaged
🫤 license matches upstream specification and is acceptable for Fedora
   (adapted for GPLv2-licensed contents of the package)
🫤 license files are included with %license in %files
   (MIT: manually included from upstream; GPLv2: manually included canonical text)
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-qapi-qga

FEDORA-2025-76fe360c68 (rust-qapi-qga-0.13.0-2.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-76fe360c68

FEDORA-2025-76fe360c68 (rust-qapi-qga-0.13.0-2.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.