Bug 2356830 (rust-qapi-codegen) - Review Request: rust-qapi-codegen - QEMU QAPI codegen helper
Summary: Review Request: rust-qapi-codegen - QEMU QAPI codegen helper
Keywords:
Status: CLOSED ERRATA
Alias: rust-qapi-codegen
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/qapi-codegen
Whiteboard:
Depends On: rust-qapi-parser
Blocks: rust-qapi-qga rust-qapi-qmp
TreeView+ depends on / blocked
 
Reported: 2025-04-02 07:17 UTC by Marc-Andre Lureau
Modified: 2025-04-07 20:13 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-04-07 20:13:02 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Comment 1 Fedora Review Service 2025-04-02 07:19:15 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8848097
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2356830-rust-qapi-codegen/fedora-rawhide-x86_64/08848097-rust-qapi-codegen/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2025-04-07 13:38:18 UTC
The Source URL you used for the COPYING file isn't valid:
https://github.com/arcnmx/qapi-rs/raw/COPYING

There's likely a ref identifier missing (like which commit corresponds to the 0.11.3 release of this crate).

Comment 3 Marc-Andre Lureau 2025-04-07 13:46:06 UTC
oh snap.. https://raw.githubusercontent.com/arcnmx/qapi-rs/refs/heads/main/COPYING

Comment 4 Fabio Valentini 2025-04-07 13:48:29 UTC
I would generally discourage using a branch name instead of a commit hash or tag here - since those are moving targets and could point at something different (or nothing at all) in the future, but it should be fine for now.

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
🫤 license file is included with %license in %files
   (manually included from upstream repo, PR submitted to include in published crates in the future)
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

Comment 5 Fedora Admin user for bugzilla script actions 2025-04-07 19:49:11 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-qapi-codegen

Comment 6 Fedora Update System 2025-04-07 20:06:33 UTC
FEDORA-2025-5695fb59fd (rust-qapi-codegen-0.11.3-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-5695fb59fd

Comment 7 Fedora Update System 2025-04-07 20:13:02 UTC
FEDORA-2025-5695fb59fd (rust-qapi-codegen-0.11.3-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.