Bug 2357172
| Summary: | Confirmation windows at the new anaconda-webui doesn't resize accordingly to fit large texts on buttons | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Geraldo Simião <geraldo.simiao.kutz> | ||||||
| Component: | anaconda-webui | Assignee: | Katerina Koukiou <kkoukiou> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | |||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 42 | CC: | awilliam, glesage, jkonecny, kkoukiou, lruzicka, mkolman, rvykydal | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | AcceptedFreezeException | ||||||||
| Fixed In Version: | anaconda-webui-33-1.fc42 | Doc Type: | --- | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2025-04-11 04:04:37 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 2291266 | ||||||||
| Attachments: |
|
||||||||
|
Description
Geraldo Simião
2025-04-03 11:26:43 UTC
Created attachment 2083217 [details]
screenshot from the window
Proposed as a Freeze Exception for 42-final by Fedora user geraldosimiao using the blocker tracking app because: Despite this doesn't block the installation and all is working as expected, I'll propose as FE because its kinda bad UX to see all this text going out the button and windows limits, looks like we doesn't car for a nice and pollished design. Thanks for reporting this issue and providing a screenshot!
The ideal solution would be to have the modal have a minimum width, like this:
.pf-v5-c-modal-box { min-width: min-content; }
An alternate, but not quite as good, approach would be to wrap the buttons, but this isn't as elegant and wouldn't solve the issue for text that's even longer (where a button's text length would be wider than the modal):
.pf-v5-c-modal-box__footer {
flex-wrap: wrap;
row-gap: var(--pf-v5-global--spacer--sm);
}
I prefer the more-elegant `min-width: min-content` approach, and think this should be the default for PatternFly, so we'll want to open up an issue for a fix there as well. Meanwhile, we should add `.pf-v5-c-modal-box { min-width: min-content; }` as a PatternFly override in Anaconda.
+4 in https://pagure.io/fedora-qa/blocker-review/issue/1829 , marking accepted FE. Upstream fix: https://github.com/rhinstaller/anaconda-webui/pull/765 FEDORA-2025-3f6a3ddd2d (anaconda-42.27.12-1.fc42 and anaconda-webui-33-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-3f6a3ddd2d Created attachment 2083853 [details]
the new build fized the issue
anaconda-42.27.12-1.fc42 and anaconda-webui-33-1.fc42 really fixed the bug, great.
FEDORA-2025-3f6a3ddd2d has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-3f6a3ddd2d` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-3f6a3ddd2d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-3f6a3ddd2d (anaconda-42.27.12-1.fc42 and anaconda-webui-33-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. |