Bug 2357172 - Confirmation windows at the new anaconda-webui doesn't resize accordingly to fit large texts on buttons
Summary: Confirmation windows at the new anaconda-webui doesn't resize accordingly to ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda-webui
Version: 42
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Katerina Koukiou
QA Contact:
URL:
Whiteboard: AcceptedFreezeException
Depends On:
Blocks: F42FinalFreezeException
TreeView+ depends on / blocked
 
Reported: 2025-04-03 11:26 UTC by Geraldo Simião
Modified: 2025-04-11 04:04 UTC (History)
7 users (show)

Fixed In Version: anaconda-webui-33-1.fc42
Clone Of:
Environment:
Last Closed: 2025-04-11 04:04:37 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
screenshot from the window (37.16 KB, image/jpeg)
2025-04-03 11:27 UTC, Geraldo Simião
no flags Details
the new build fized the issue (63.21 KB, image/jpeg)
2025-04-08 12:01 UTC, Geraldo Simião
no flags Details

Description Geraldo Simião 2025-04-03 11:26:43 UTC
As show at the screenshot attached, when ther's medium to large texts at the buttons, the overal window and the button too, doesn't resize to fit all text.

Reproducible: Always

Steps to Reproduce:
1.Start installation of f42 workstation
2.Set some partition scheme that doesn't achieve the correct requirements

Actual Results:  
the warn window shows with texts going out the right button and windows limmits

Expected Results:  
nice shaped window with texts and buttons correctly wraped

already told @kkoukiou about it at the QA matrix room
confirmed with this build here https://adamwill.fedorapeople.org/04891897-Fedora-Workstation-Live-x86_64-FEDORA-2025-f4b60a3d74.iso

Comment 1 Geraldo Simião 2025-04-03 11:27:35 UTC
Created attachment 2083217 [details]
screenshot from the window

Comment 2 Fedora Blocker Bugs Application 2025-04-03 11:31:36 UTC
Proposed as a Freeze Exception for 42-final by Fedora user geraldosimiao using the blocker tracking app because:

 Despite this doesn't block the installation and all is working as expected, I'll propose as FE because its kinda bad UX to see all this text going out the button and windows limits, looks like we doesn't car for a nice and pollished design.

Comment 3 Garrett LeSage 2025-04-03 12:38:39 UTC
Thanks for reporting this issue and providing a screenshot!

The ideal solution would be to have the modal have a minimum width, like this:

    .pf-v5-c-modal-box { min-width: min-content; }


An alternate, but not quite as good, approach would be to wrap the buttons, but this isn't as elegant and wouldn't solve the issue for text that's even longer (where a button's text length would be wider than the modal):

    .pf-v5-c-modal-box__footer {
      flex-wrap: wrap;
      row-gap: var(--pf-v5-global--spacer--sm);
    }


I prefer the more-elegant `min-width: min-content` approach, and think this should be the default for PatternFly, so we'll want to open up an issue for a fix there as well. Meanwhile, we should add `.pf-v5-c-modal-box { min-width: min-content; }` as a PatternFly override in Anaconda.

Comment 4 Adam Williamson 2025-04-03 21:46:26 UTC
+4 in https://pagure.io/fedora-qa/blocker-review/issue/1829 , marking accepted FE.

Comment 5 Katerina Koukiou 2025-04-07 08:53:01 UTC
Upstream fix: https://github.com/rhinstaller/anaconda-webui/pull/765

Comment 6 Fedora Update System 2025-04-08 10:50:57 UTC
FEDORA-2025-3f6a3ddd2d (anaconda-42.27.12-1.fc42 and anaconda-webui-33-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-3f6a3ddd2d

Comment 7 Geraldo Simião 2025-04-08 12:01:39 UTC
Created attachment 2083853 [details]
the new build fized the issue

anaconda-42.27.12-1.fc42 and anaconda-webui-33-1.fc42 really fixed the bug, great.

Comment 8 Fedora Update System 2025-04-09 02:39:04 UTC
FEDORA-2025-3f6a3ddd2d has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-3f6a3ddd2d`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-3f6a3ddd2d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2025-04-11 04:04:37 UTC
FEDORA-2025-3f6a3ddd2d (anaconda-42.27.12-1.fc42 and anaconda-webui-33-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.