Bug 2358529
| Summary: | Review Request: rust-monostate-impl - Implementation detail of the monostate crate | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Alexander Lent <lx> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | Flags: | decathorpe:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://crates.io/crates/monostate-impl | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2025-05-16 05:17:09 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2358530 | ||
|
Description
Alexander Lent
2025-04-09 01:35:01 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8881503 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2358529-rust-monostate-impl/fedora-rawhide-x86_64/08881503-rust-monostate-impl/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass (there are no tests) ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional) The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-monostate-impl FEDORA-2025-6a2ed3e920 (rust-monostate-impl-0.1.14-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-6a2ed3e920 FEDORA-2025-6a2ed3e920 (rust-monostate-impl-0.1.14-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report. I noticed that you set the Monitoring setting for this package to "All" updates *with* Scratch builds. I would recommend to change it to just "Monitoring". The patches done by (and in turn, the scratch builds submitted by) the release-monitoring service are not useful for Rust packages, since they MUST (at least for now) be re-generated by rust2rpm for every new upstream release to ensure that the spec file produces working and valid packages. Thanks for the recommendation; I will switch it now. I was operating on auto-pilot and forgot about the generator step. :) Thanks for the recommendation; I will switch it now. I was operating on auto-pilot and forgot about the generator step. :) |