Bug 2358529 - Review Request: rust-monostate-impl - Implementation detail of the monostate crate
Summary: Review Request: rust-monostate-impl - Implementation detail of the monostate ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/monostate-impl
Whiteboard:
Depends On:
Blocks: 2358530
TreeView+ depends on / blocked
 
Reported: 2025-04-09 01:35 UTC by Alexander Lent
Modified: 2025-05-16 19:52 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-05-16 05:17:09 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Alexander Lent 2025-04-09 01:35:01 UTC
Spec URL: https://gist.github.com/xanderlent/db1f4626c930145bd027726b5d6480aa/raw/e9d7e98d8f326c83e6b2e87fb53d8e0d2ccbdb37/rust-monostate-impl.spec
SRPM URL: https://gist.github.com/xanderlent/db1f4626c930145bd027726b5d6480aa/raw/e9d7e98d8f326c83e6b2e87fb53d8e0d2ccbdb37/rust-monostate-impl-0.1.14-1.fc41.src.rpm
Description: Implementation detail of the monostate crate
Fedora Account System Username: xanderlent

This is a dep of rust-monostate, which is a dep of rust-tokenizers.

Comment 1 Fedora Review Service 2025-04-09 15:06:04 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8881503
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2358529-rust-monostate-impl/fedora-rawhide-x86_64/08881503-rust-monostate-impl/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2025-05-10 15:48:54 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass (there are no tests)
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

Comment 3 Fedora Admin user for bugzilla script actions 2025-05-16 04:51:58 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-monostate-impl

Comment 4 Fedora Update System 2025-05-16 05:13:01 UTC
FEDORA-2025-6a2ed3e920 (rust-monostate-impl-0.1.14-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-6a2ed3e920

Comment 5 Fedora Update System 2025-05-16 05:17:09 UTC
FEDORA-2025-6a2ed3e920 (rust-monostate-impl-0.1.14-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 Fabio Valentini 2025-05-16 19:45:29 UTC
I noticed that you set the Monitoring setting for this package to "All" updates *with* Scratch builds. I would recommend to change it to just "Monitoring". The patches done by (and in turn, the scratch builds submitted by) the release-monitoring service are not useful for Rust packages, since they MUST (at least for now) be re-generated by rust2rpm for every new upstream release to ensure that the spec file produces working and valid packages.

Comment 7 Alexander Lent 2025-05-16 19:52:37 UTC
Thanks for the recommendation; I will switch it now.

I was operating on auto-pilot and forgot about the generator step. :)

Comment 8 Alexander Lent 2025-05-16 19:52:37 UTC
Thanks for the recommendation; I will switch it now.

I was operating on auto-pilot and forgot about the generator step. :)


Note You need to log in before you can comment on or make changes to this bug.