Bug 2358537

Summary: Review Request: rust-unicode-normalization-alignments - Unicode character composition and decomposition utilities with alignment
Product: [Fedora] Fedora Reporter: Alexander Lent <lx>
Component: Package ReviewAssignee: Cristian Le <fedora>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: fedora: fedora-review+
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/unicode-normalization-alignments
Whiteboard:
Fixed In Version: Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-07-22 22:07:21 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2358553    

Description Alexander Lent 2025-04-09 02:05:27 UTC
Spec URL: https://gist.github.com/xanderlent/044be54d47228c5013ad4a58bb69eee5/raw/afa3f90e24e57e18c478a84dd305be6d7a9960c9/rust-unicode-normalization-alignments.spec
SRPM URL: https://gist.github.com/xanderlent/044be54d47228c5013ad4a58bb69eee5/raw/afa3f90e24e57e18c478a84dd305be6d7a9960c9/rust-unicode-normalization-alignments-0.1.12-1.fc41.src.rpm
Description: Unicode character composition and decomposition utilities with alignment
Fedora Account System Username: xanderlent

This is another dependency of rust-tokenizers. It's a fork of unicode-normalization which provides an API needed for tokenization, apparently.

Comment 1 Fedora Review Service 2025-04-09 15:05:12 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8881506
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2358537-rust-unicode-normalization-alignments/fedora-rawhide-x86_64/08881506-rust-unicode-normalization-alignments/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Cristian Le 2025-07-21 14:15:35 UTC
This is a 6 year-old fork. Would be nice if tokenizer did not need such dependency, but I guess it would be fine.

Just one note, could you drop the scripts folder (probably in a prep.post)?

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

Comment 3 Fedora Admin user for bugzilla script actions 2025-07-22 20:45:10 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-unicode-normalization-alignments

Comment 4 Alexander Lent 2025-07-22 20:46:07 UTC
Thanks for the review! I dropped the scripts and benches folders from the source; let me know if you have any other suggestions.

Comment 5 Fedora Update System 2025-07-22 21:07:36 UTC
FEDORA-2025-d11c12852d (rust-unicode-normalization-alignments-0.1.12-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-d11c12852d

Comment 6 Fedora Update System 2025-07-22 22:07:21 UTC
FEDORA-2025-d11c12852d (rust-unicode-normalization-alignments-0.1.12-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.