Bug 2358537 - Review Request: rust-unicode-normalization-alignments - Unicode character composition and decomposition utilities with alignment
Summary: Review Request: rust-unicode-normalization-alignments - Unicode character com...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Cristian Le
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/unicode-norm...
Whiteboard:
Depends On:
Blocks: 2358553
TreeView+ depends on / blocked
 
Reported: 2025-04-09 02:05 UTC by Alexander Lent
Modified: 2025-07-22 22:07 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-07-22 22:07:21 UTC
Type: ---
Embargoed:
fedora: fedora-review+


Attachments (Terms of Use)

Description Alexander Lent 2025-04-09 02:05:27 UTC
Spec URL: https://gist.github.com/xanderlent/044be54d47228c5013ad4a58bb69eee5/raw/afa3f90e24e57e18c478a84dd305be6d7a9960c9/rust-unicode-normalization-alignments.spec
SRPM URL: https://gist.github.com/xanderlent/044be54d47228c5013ad4a58bb69eee5/raw/afa3f90e24e57e18c478a84dd305be6d7a9960c9/rust-unicode-normalization-alignments-0.1.12-1.fc41.src.rpm
Description: Unicode character composition and decomposition utilities with alignment
Fedora Account System Username: xanderlent

This is another dependency of rust-tokenizers. It's a fork of unicode-normalization which provides an API needed for tokenization, apparently.

Comment 1 Fedora Review Service 2025-04-09 15:05:12 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8881506
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2358537-rust-unicode-normalization-alignments/fedora-rawhide-x86_64/08881506-rust-unicode-normalization-alignments/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Cristian Le 2025-07-21 14:15:35 UTC
This is a 6 year-old fork. Would be nice if tokenizer did not need such dependency, but I guess it would be fine.

Just one note, could you drop the scripts folder (probably in a prep.post)?

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

Comment 3 Fedora Admin user for bugzilla script actions 2025-07-22 20:45:10 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-unicode-normalization-alignments

Comment 4 Alexander Lent 2025-07-22 20:46:07 UTC
Thanks for the review! I dropped the scripts and benches folders from the source; let me know if you have any other suggestions.

Comment 5 Fedora Update System 2025-07-22 21:07:36 UTC
FEDORA-2025-d11c12852d (rust-unicode-normalization-alignments-0.1.12-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-d11c12852d

Comment 6 Fedora Update System 2025-07-22 22:07:21 UTC
FEDORA-2025-d11c12852d (rust-unicode-normalization-alignments-0.1.12-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.