Bug 2358642

Summary: Review Request: rust-idna_adapter - Back end adapter for idna
Product: [Fedora] Fedora Reporter: Ben Beasley <code>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/idna_adapter
Whiteboard:
Fixed In Version: Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-04-10 19:54:56 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2358527, 2358606    
Bug Blocks: 2291175    

Description Ben Beasley 2025-04-09 15:34:26 UTC
Spec URL: https://music.fedorapeople.org/rust-idna_adapter.spec
SRPM URL: https://music.fedorapeople.org/rust-idna_adapter-1.2.0-1.fc41.src.rpm
Description: Back end adapter for idna.
Fedora Account System Username: music

This is a prerequisite for updating rust-idna to version 1.x.

https://release-monitoring.org/project/377643/

COPR build with fedora-review enabled:
https://copr.fedorainfracloud.org/coprs/music/idna1/build/8881607/

Comment 1 Fedora Review Service 2025-04-09 15:37:03 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8881621
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2358642-rust-idna_adapter/fedora-rawhide-x86_64/08881621-rust-idna_adapter/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2025-04-10 16:32:06 UTC
Reviewed against locally built packages for #2358290, #2358507, #2358527, and #2358606.

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
   (there are no tests - and since "all(empty set)" is True ...)
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

Comment 3 Ben Beasley 2025-04-10 17:17:01 UTC
Thank you for the review!

Comment 4 Fedora Admin user for bugzilla script actions 2025-04-10 17:23:22 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-idna_adapter

Comment 5 Fedora Update System 2025-04-10 19:52:53 UTC
FEDORA-2025-35746f1517 (rust-idna_adapter-1.2.0-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-35746f1517

Comment 6 Fedora Update System 2025-04-10 19:54:56 UTC
FEDORA-2025-35746f1517 (rust-idna_adapter-1.2.0-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2025-04-11 00:30:56 UTC
FEDORA-2025-04847cb65d (rust-icu_collections-1.5.0-3.fc42, rust-icu_locid-1.5.0-2.fc42, and 15 more) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-04847cb65d

Comment 8 Fedora Update System 2025-04-11 00:31:07 UTC
FEDORA-2025-cd87acc644 (rust-icu_collections-1.5.0-3.fc41, rust-icu_locid-1.5.0-2.fc41, and 15 more) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-cd87acc644

Comment 9 Fedora Update System 2025-04-11 00:31:24 UTC
FEDORA-2025-e923d51676 (rust-icu_collections-1.5.0-3.fc40, rust-icu_locid-1.5.0-2.fc40, and 15 more) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-e923d51676

Comment 10 Fedora Update System 2025-04-11 00:31:31 UTC
FEDORA-EPEL-2025-3fd4fbc045 (rust-atoi-2.0.0-2.el10_1, rust-detone-1.0.0-4.el10_1, and 20 more) has been submitted as an update to Fedora EPEL 10.1.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-3fd4fbc045

Comment 11 Fedora Update System 2025-04-11 00:31:43 UTC
FEDORA-EPEL-2025-c872f3c0bf (rust-atoi-2.0.0-2.el10_0, rust-detone-1.0.0-4.el10_0, and 21 more) has been submitted as an update to Fedora EPEL 10.0.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-c872f3c0bf

Comment 12 Fedora Update System 2025-04-11 00:32:09 UTC
FEDORA-EPEL-2025-de34e6ceb0 (rust-icu_locid_transform-1.5.0-1.el9, rust-icu_normalizer-1.5.0-2.el9, and 3 more) has been submitted as an update to Fedora EPEL 9.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-de34e6ceb0

Comment 13 Fedora Update System 2025-04-13 02:40:00 UTC
FEDORA-2025-04847cb65d has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-04847cb65d`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-04847cb65d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2025-04-13 03:13:53 UTC
FEDORA-EPEL-2025-3fd4fbc045 has been pushed to the Fedora EPEL 10.1 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-3fd4fbc045

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2025-04-13 03:17:14 UTC
FEDORA-2025-e923d51676 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-e923d51676`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-e923d51676

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Fedora Update System 2025-04-13 03:17:15 UTC
FEDORA-2025-cd87acc644 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-cd87acc644`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-cd87acc644

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2025-04-13 03:25:08 UTC
FEDORA-EPEL-2025-c872f3c0bf has been pushed to the Fedora EPEL 10.0 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-c872f3c0bf

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 18 Fedora Update System 2025-04-15 16:52:22 UTC
FEDORA-EPEL-2025-de34e6ceb0 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-de34e6ceb0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 19 Fedora Update System 2025-04-20 04:22:02 UTC
FEDORA-2025-04847cb65d (python-pydantic-core-2.27.2-5.fc42, rust-adblock-0.9.6-1.fc42, and 28 more) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 20 Fedora Update System 2025-04-21 00:31:32 UTC
FEDORA-EPEL-2025-3fd4fbc045 (python-pydantic-core-2.23.4-2.el10_1, rust-adblock-0.9.6-1.el10_1, and 29 more) has been pushed to the Fedora EPEL 10.1 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 21 Fedora Update System 2025-04-21 00:52:30 UTC
FEDORA-EPEL-2025-c872f3c0bf (rust-atoi-2.0.0-2.el10_0, rust-detone-1.0.0-4.el10_0, and 21 more) has been pushed to the Fedora EPEL 10.0 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 22 Fedora Update System 2025-04-21 01:40:15 UTC
FEDORA-2025-e923d51676 (python-pydantic-core-2.20.1-3.fc40, rust-adblock-0.9.6-1.fc40, and 28 more) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 23 Fedora Update System 2025-04-21 16:45:51 UTC
FEDORA-2025-cd87acc644 (python-pydantic-core-2.27.2-5.fc41, rust-adblock-0.9.6-1.fc41, and 28 more) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 24 Fedora Update System 2025-04-22 00:43:56 UTC
FEDORA-EPEL-2025-de34e6ceb0 (rust-adblock-0.9.6-1.el9, rust-addr-0.15.6-2.el9, and 12 more) has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.