Created attachment 2084042 [details] Configuration file for rust2rpm Spec URL: https://music.fedorapeople.org/rust-icu_normalizer.spec SRPM URL: https://music.fedorapeople.org/rust-icu_normalizer-1.5.0-1.fc41.src.rpm Description: API for normalizing text into Unicode Normalization Forms . Fedora Account System Username: music This is part of the ICU4X stack (version 1.5). https://release-monitoring.org/project/377627/ COPR build with fedora-review enabled: https://copr.fedorainfracloud.org/coprs/music/idna1/build/8875813/
Copr build: https://copr.fedorainfracloud.org/coprs/build/8881522 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2358606-rust-icu_normalizer/fedora-rawhide-x86_64/08881522-rust-icu_normalizer/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/8881521 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2358606-rust-icu_normalizer/fedora-rawhide-x86_64/08881521-rust-icu_normalizer/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Here’s a fresh COPR build, now with all dependencies available in EPEL9/EPEL10. https://copr.fedorainfracloud.org/coprs/music/idna1/build/8876500/
Reviewed against locally built packages for #2358290, #2358507, and #2358527. There is benchmark input data in benches/data (licensed Unicode-3.0, so that's at least OK), but you could drop those files from built packages. It's also a bit funny that benches/data/* files are *included* in published crates, but tests/data/* files are explicitly *excluded* with the documented reasoning of "This is a placeholder in the interest of keeping the repository size smaller". === Patches are reasonable, well-documented, and acceptable to remain downstream-only. Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide 🫤 test suite is run and all unit tests pass (some tests that cannot reasonably be run from published crates are disabled) ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional)
Thank you for the review! Looking at https://github.com/unicode-org/icu4x, all of the include patterns are inherited from the workspace, so it looks like upstream means to ship test and benchmark data in general. It’s a little weird that they bother with the placeholder “trick” here when the git repo is already in the hundreds of megabytes, and other crates like icu_segmenter have several megabytes of test data, but I suppose weird is OK. It might make sense for me to omit the benchmark data as a downstream patch to Cargo.toml. It’s not huge, but nothing in Fedora will use it. I’ll investigate that after importing.
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-icu_normalizer
FEDORA-2025-c73672091b (rust-icu_normalizer-1.5.0-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-c73672091b
FEDORA-2025-c73672091b (rust-icu_normalizer-1.5.0-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-04847cb65d (rust-icu_collections-1.5.0-3.fc42, rust-icu_locid-1.5.0-2.fc42, and 15 more) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-04847cb65d
FEDORA-2025-cd87acc644 (rust-icu_collections-1.5.0-3.fc41, rust-icu_locid-1.5.0-2.fc41, and 15 more) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-cd87acc644
FEDORA-2025-e923d51676 (rust-icu_collections-1.5.0-3.fc40, rust-icu_locid-1.5.0-2.fc40, and 15 more) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2025-e923d51676
FEDORA-EPEL-2025-3fd4fbc045 (rust-atoi-2.0.0-2.el10_1, rust-detone-1.0.0-4.el10_1, and 20 more) has been submitted as an update to Fedora EPEL 10.1. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-3fd4fbc045
FEDORA-EPEL-2025-c872f3c0bf (rust-atoi-2.0.0-2.el10_0, rust-detone-1.0.0-4.el10_0, and 21 more) has been submitted as an update to Fedora EPEL 10.0. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-c872f3c0bf
FEDORA-EPEL-2025-de34e6ceb0 (rust-icu_locid_transform-1.5.0-1.el9, rust-icu_normalizer-1.5.0-2.el9, and 3 more) has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-de34e6ceb0
FEDORA-2025-04847cb65d has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-04847cb65d` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-04847cb65d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2025-3fd4fbc045 has been pushed to the Fedora EPEL 10.1 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-3fd4fbc045 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-cd87acc644 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-cd87acc644` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-cd87acc644 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2025-c872f3c0bf has been pushed to the Fedora EPEL 10.0 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-c872f3c0bf See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2025-de34e6ceb0 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-de34e6ceb0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-04847cb65d (python-pydantic-core-2.27.2-5.fc42, rust-adblock-0.9.6-1.fc42, and 28 more) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2025-3fd4fbc045 (python-pydantic-core-2.23.4-2.el10_1, rust-adblock-0.9.6-1.el10_1, and 29 more) has been pushed to the Fedora EPEL 10.1 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2025-c872f3c0bf (rust-atoi-2.0.0-2.el10_0, rust-detone-1.0.0-4.el10_0, and 21 more) has been pushed to the Fedora EPEL 10.0 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-e923d51676 (python-pydantic-core-2.20.1-3.fc40, rust-adblock-0.9.6-1.fc40, and 28 more) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-cd87acc644 (python-pydantic-core-2.27.2-5.fc41, rust-adblock-0.9.6-1.fc41, and 28 more) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2025-de34e6ceb0 (rust-adblock-0.9.6-1.el9, rust-addr-0.15.6-2.el9, and 12 more) has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report.