Bug 2360688
| Summary: | Review Request: perl-Mail-ListDetector - Perl extension for detecting mailing list messages | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Oliver <mavit> |
| Component: | Package Review | Assignee: | Xavier Bachelot <xavier> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, xavier |
| Target Milestone: | --- | Flags: | xavier:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://metacpan.org/dist/Mail-ListDetector | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2025-08-06 13:30:31 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2360687 | ||
|
Description
Peter Oliver
2025-04-17 12:34:38 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8914877 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2360688-perl-mail-listdetector/fedora-rawhide-x86_64/08914877-perl-Mail-ListDetector/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. - It's is usually preferred to reference the tarball by module rather than by author. Source0 could be changed to use https://cpan.metacpan.org/modules/by-module/Mail/Mail-ListDetector-%{version}.tar.gz - add BR: coreutils for _fixperms macro which uses chmod - in files section, listing could be much simpler: """ %{_mandir}/man3/Mail::ListDetector*.3pm* %{perl_vendorlib}/Mail/ %{perl_vendorlib}/auto/Mail/ """ - BuildRequires needs to be checked, some compile and runtime BRs seem to be missing. Tangerine may help. Missing : AutoLoader (compile) Exporter (runtime) FileHandle (test) strict (compile) vars (compile) warnings (compile) (In reply to Xavier Bachelot from comment #2) > - in files section, listing could be much simpler: > """ > %{_mandir}/man3/Mail::ListDetector*.3pm* > %{perl_vendorlib}/Mail/ > %{perl_vendorlib}/auto/Mail/ > """ The packaging guidelines say that wildcards should not be used in shared directories (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists). The directories you suggest are shared with other CPAN modules. Other suggestions implemented. Thanks for the review. Spec URL: https://download.copr.fedorainfracloud.org/results/mavit/perl-Mail-Audit/fedora-rawhide-x86_64/09318584-perl-Mail-ListDetector/perl-Mail-ListDetector.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mavit/perl-Mail-Audit/fedora-rawhide-x86_64/09318584-perl-Mail-ListDetector/perl-Mail-ListDetector-1.04-2.fc43.src.rpm A wildcard that globs everything is not ok, using a wildcard while still being specific enough is.
%{_mandir}/man3/* is not ok
%{_mandir}/man3/Mail::ListDetector*.3pm* is ok
You're right about the directory being shared by other modules, however this is how it is done for perl modules.
See https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/
This and the wildcard restriction above leads to what I suggested.
About BuildRequires: /usr/bin/chmod
While this would work, a requirement on a file is more costly to resolve and a requirement against a package is preferred, thus
BuildRequires: coreutils
Spec URL: https://download.copr.fedorainfracloud.org/results/mavit/perl-Mail-Audit/fedora-rawhide-x86_64/09336906-perl-Mail-ListDetector/perl-Mail-ListDetector.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mavit/perl-Mail-Audit/fedora-rawhide-x86_64/09336906-perl-Mail-ListDetector/perl-Mail-ListDetector-1.04-3.fc43.src.rpm I may not have been clear enough, sorry about that.
While the manpages are ok now, the perl files in the files section is still not correct:
%{perl_vendorlib}/*
should be
%{perl_vendorlib}/Mail/
%{perl_vendorlib}/auto/Mail/
Apart from that, everything looks good, I will proceed with the formal review.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/#_directory_ownership says %{perl_vendorlib}/* https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists also says "Packagers SHOULD NOT simply glob everything under a shared directory." Both rules combined gives what I suggested. Anyway, your call, I'm not going to block on that. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Source0 is incorrect https://cpan.metacpan.org/modules/by-module/Mail-ListDetector-%{version}.tar.gz should be https://cpan.metacpan.org/modules/by-module/Mail/Mail-ListDetector-%{version}.tar.gz ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* The Perl 5 License". 65 files have unknown license. Detailed output of licensecheck in /tmp/2360688-perl-Mail-ListDetector/licensecheck.txt [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/perl5/vendor_perl/Mail(spamassassin, perl-Mail-MboxParser, perl-Mail-Server-IMAP4, perl-Mail-Procmail, perl-MailTools, perl-Mail- Transport, perl-Mail-Box, perl-User-Identity, perl-Mail-DKIM, perl- Mail-DMARC, perl-Mail-Message, perl-Mail-IMAPTalk, perl-Mail- POP3Client, perl-Mail-AuthenticationResults, perl-Mail-RFC822-Address, perl-Mail-Sender, perl-Mail-JMAPTalk, perl-Amavis, perl-Mail-Alias, perl-Mail-Sendmail, perl-Mail-Box-IMAP4, perl-Mail-IMAPClient, perl- Mail-Mbox-MessageParser, perl-Mail-SPF-Iterator, perl-Mail-Box-POP3), /usr/share/perl5/vendor_perl/auto(perl-Pegex, perl-QWizard, perl- Lingua-EN-Alphabet-Shaw, perl-File-ShareDir, perl-Net-CLI-Interact, perl-RDF-NS, perl-WebService-Rajce, perl-Dist-Milla, perl-Module- Manifest-Skip, perl-Alien-ProtoBuf, perl-Data-Random, perl-Log-Agent, perl-ORLite-Mirror, perl-Text-VimColor, perl-Config-Simple, perl- DepGen-Perl-Tests, perl-Shipwright, perl-Tree-R, perl-Crypt-CAST5_PP, perl-Inline-Module, perl-Mail-DMARC, perl-Affix-Infix2Postfix, perl- SQL-Translator, perl-Catalyst-Devel, perl-Ace, swatchdog, perl-LWP- Authen-Negotiate, perl-WWW-Babelfish, perl-Data-Flow, perl-Data- Uniqid, perl-CGI-Application-Plugin-SuperForm, perl-Swim, perl-Data- Dump-Color, perl-Memoize-ExpireLRU, perl-App-PFT, perl-Dist-Zilla, perl-HTML-FormFu, perl-Dancer2, perl-HTML-FormHandler, perl-Module- Starter-Plugin-CGIApp, perl-Net-IPv4Addr, perl-Mojo-RabbitMQ-Client, perl-PDF-Reuse, perl-DBICx-AutoDoc, perl-TestML1) [-]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1594 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [x]: Package contains the mandatory BuildRequires and Requires:. [x]: CPAN urls should be non-versioned. ===== SHOULD items ===== Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://cpan.metacpan.org/modules/by-module/Mail- ListDetector-1.04.tar.gz See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [-]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define autorelease(e:s:pb:n) %{?-p:0.}%{lua: [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: perl-Mail-ListDetector-1.04-3.fc43.noarch.rpm perl-Mail-ListDetector-1.04-3.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpvn4ryx1h')] checks: 32, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 7 filtered, 0 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 3 filtered, 0 badness; has taken 0.0 s Requires -------- perl-Mail-ListDetector (rpmlib, GLIBC filtered): perl(AutoLoader) perl(Carp) perl(Email::Abstract) perl(Email::Valid) perl(Exporter) perl(Mail::ListDetector::Detector::Base) perl(Mail::ListDetector::Detector::RFC2369) perl(Mail::ListDetector::Detector::RFC2919) perl(Mail::ListDetector::List) perl(URI) perl(base) perl(strict) perl(vars) perl(warnings) perl-libs Provides -------- perl-Mail-ListDetector: perl(Mail::ListDetector) perl(Mail::ListDetector::Detector::AutoShare) perl(Mail::ListDetector::Detector::Base) perl(Mail::ListDetector::Detector::CommuniGate) perl(Mail::ListDetector::Detector::CommuniGatePro) perl(Mail::ListDetector::Detector::Ecartis) perl(Mail::ListDetector::Detector::Ezmlm) perl(Mail::ListDetector::Detector::Fml) perl(Mail::ListDetector::Detector::GoogleGroups) perl(Mail::ListDetector::Detector::LetterRip) perl(Mail::ListDetector::Detector::ListSTAR) perl(Mail::ListDetector::Detector::Listar) perl(Mail::ListDetector::Detector::Listbox) perl(Mail::ListDetector::Detector::Listserv) perl(Mail::ListDetector::Detector::Lyris) perl(Mail::ListDetector::Detector::Mailman) perl(Mail::ListDetector::Detector::Majordomo) perl(Mail::ListDetector::Detector::Onelist) perl(Mail::ListDetector::Detector::RFC2369) perl(Mail::ListDetector::Detector::RFC2919) perl(Mail::ListDetector::Detector::Smartlist) perl(Mail::ListDetector::Detector::Yahoogroups) perl(Mail::ListDetector::List) perl-Mail-ListDetector Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2360688 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, Perl Disabled plugins: Ocaml, Python, Haskell, SugarActivity, PHP, fonts, Java, R, C/C++ Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Thanks again for the review. Spec URL: https://download.copr.fedorainfracloud.org/results/mavit/perl-Mail-Audit/fedora-rawhide-x86_64/09344705-perl-Mail-ListDetector/perl-Mail-ListDetector.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mavit/perl-Mail-Audit/fedora-rawhide-x86_64/09344705-perl-Mail-ListDetector/perl-Mail-ListDetector-1.04-4.fc43.src.rpm Package is APPROVED. The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Mail-ListDetector FEDORA-2025-8c8970b44a (perl-Mail-Audit-List-1.853-3.fc42 and perl-Mail-ListDetector-1.04-5.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-8c8970b44a FEDORA-2025-8c8970b44a has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-8c8970b44a \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-8c8970b44a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-8c8970b44a (perl-Mail-Audit-List-1.853-3.fc42 and perl-Mail-ListDetector-1.04-5.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. |