Spec URL: https://download.copr.fedorainfracloud.org/results/mavit/perl-Mail-Audit/fedora-rawhide-x86_64/08914853-perl-Mail-Audit-List/perl-Mail-Audit-List.spec< SRPM URL: https://download.copr.fedorainfracloud.org/results/mavit/perl-Mail-Audit/fedora-rawhide-x86_64/08914853-perl-Mail-Audit-List/perl-Mail-Audit-List-1.853-1.fc43.src.rpm Description: Mail::Audit plugin for automatic list delivery Fedora Account System Username: mavit
Copr build: https://copr.fedorainfracloud.org/coprs/build/8914876 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2360687-perl-mail-audit-list/fedora-rawhide-x86_64/08914876-perl-Mail-Audit-List/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://download.copr.fedorainfracloud.org/results/mavit/perl-Mail-Audit/fedora-rawhide-x86_64/08914853-perl-Mail-Audit-List/perl-Mail-Audit-List.spec
- Source0 could use a by-module path rather than by-author for more stability https://cpan.metacpan.org/modules/by-module/Mail/Mail-Audit-List-%{version}.tar.gz - Missing BR: coreutils for _fixperms macro - in files section: %{perl_vendorlib}/Mail/Audit/List.pm thus %{perl_vendorlib}/Mail/Audit/ and %{perl_vendorlib}/Mail/ are not owned %{perl_vendorlib}/Mail/ would fix this
Thanks for the review. (In reply to Xavier Bachelot from comment #3) > - in files section: > thus %{perl_vendorlib}/Mail/Audit/ and %{perl_vendorlib}/Mail/ are not owned These directories are owned by packages on which this one depends. Other suggestions applied. Spec URL: https://download.copr.fedorainfracloud.org/results/mavit/perl-Mail-Audit/fedora-rawhide-x86_64/09350521-perl-Mail-Audit-List/perl-Mail-Audit-List.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mavit/perl-Mail-Audit/fedora-rawhide-x86_64/09350521-perl-Mail-Audit-List/perl-Mail-Audit-List-1.853-2.fc43.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 1 and/or The Perl 5 License". 12 files have unknown license. Detailed output of licensecheck in /tmp/2360687-perl-Mail-Audit- List/licensecheck.txt [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [-]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 647 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [x]: Package contains the mandatory BuildRequires and Requires:. [x]: CPAN urls should be non-versioned. ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [-]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define autorelease(e:s:pb:n) %{?-p:0.}%{lua: [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: perl-Mail-Audit-List-1.853-2.fc43.noarch.rpm perl-Mail-Audit-List-1.853-2.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpbuix6ne7')] checks: 32, packages: 2 perl-Mail-Audit-List.noarch: E: spelling-error ('mainbox', '%description -l en_US mainbox -> mailbox, ma inbox, ma-inbox') perl-Mail-Audit-List.noarch: E: spelling-error ('ListDetector', '%description -l en_US ListDetector -> List Detector, List-Detector, Postdated') perl-Mail-Audit-List.src: E: spelling-error ('mainbox', '%description -l en_US mainbox -> mailbox, ma inbox, ma-inbox') perl-Mail-Audit-List.src: E: spelling-error ('ListDetector', '%description -l en_US ListDetector -> List Detector, List-Detector, Postdated') perl-Mail-Audit-List.noarch: E: incorrect-fsf-address /usr/share/licenses/perl-Mail-Audit-List/LICENSE 2 packages and 0 specfiles checked; 5 errors, 0 warnings, 7 filtered, 5 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 perl-Mail-Audit-List.noarch: E: spelling-error ('mainbox', '%description -l en_US mainbox -> mailbox, ma inbox, ma-inbox') perl-Mail-Audit-List.noarch: E: spelling-error ('ListDetector', '%description -l en_US ListDetector -> List Detector, List-detector, Detector') perl-Mail-Audit-List.noarch: E: incorrect-fsf-address /usr/share/licenses/perl-Mail-Audit-List/LICENSE 1 packages and 0 specfiles checked; 3 errors, 0 warnings, 3 filtered, 3 badness; has taken 0.1 s Source checksums ---------------- https://cpan.metacpan.org/modules/by-module/Mail/Mail-Audit-List-1.853.tar.gz : CHECKSUM(SHA256) this package : fadb1d245c2dc3a690f5a33c7c55b01b8ae745d91607ec39abca10bbff3d203b CHECKSUM(SHA256) upstream package : fadb1d245c2dc3a690f5a33c7c55b01b8ae745d91607ec39abca10bbff3d203b Requires -------- perl-Mail-Audit-List (rpmlib, GLIBC filtered): perl(Mail::Audit) perl(Mail::ListDetector) perl(strict) perl-libs Provides -------- perl-Mail-Audit-List: perl(Mail::Audit::List) perl-Mail-Audit-List Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2360687 Buildroot used: fedora-rawhide-x86_64 Active plugins: Perl, Generic, Shell-api Disabled plugins: SugarActivity, R, fonts, C/C++, Haskell, Python, Ocaml, PHP, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Package is APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Mail-Audit-List
FEDORA-2025-8c8970b44a (perl-Mail-Audit-List-1.853-3.fc42 and perl-Mail-ListDetector-1.04-5.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-8c8970b44a
FEDORA-2025-8c8970b44a has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-8c8970b44a \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-8c8970b44a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-8c8970b44a (perl-Mail-Audit-List-1.853-3.fc42 and perl-Mail-ListDetector-1.04-5.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.