Bug 2362270

Summary:

Review Request: yumex - Yum Extender graphical package management tool

Product:

[Fedora] Fedora

Reporter:

Tim Lauridsen <tim.lauridsen>

Component:

Package Review

Assignee:

Neal Gompa <ngompa13>

Status:

ASSIGNED ---

QA Contact:

Fedora Extras Quality Assurance <extras-qa>

Severity:

medium

Docs Contact:

Priority:

medium

Version:

rawhide

CC:

ngompa13, package-review

Target Milestone:

---

Flags:

ngompa13: fedora-review?

Target Release:

---

Hardware:

All

OS:

Linux

URL:

https://github.com/timlau/yumex-ng

Whiteboard:

Unretirement

Fixed In Version:

Doc Type:

---

Doc Text:

Story Points:

---

Clone Of:

Environment:

Last Closed:

Type:

---

Regression:

---

Mount Type:

---

Documentation:

---

CRM:

Verified Versions:

Category:

---

oVirt Team:

---

RHEL 7.3 requirements from Atomic Host:

Cloudforms Team:

---

Target Upstream Version:

Embargoed:

Attachments:

Description	Flags
The .spec file difference from Copr build 8966473 to 8966615	none
The .spec file difference from Copr build 8966615 to 8966667	none
The .spec file difference from Copr build 8966667 to 8967061	none
The .spec file difference from Copr build 8967061 to 8967105	none
The .spec file difference from Copr build 8967105 to 8967335	none

Description Tim Lauridsen 2025-04-25 08:55:55 UTC

Spec URL: https://raw.githubusercontent.com/timlau/yumex-ng/refs/heads/5.2.x/yumex.spec
SRPM URL: https://github.com/timlau/yumex-ng/releases/download/yumex-5.2.0/yumex-5.2.0-1.fc42.src.rpm
Description: Yum Extender graphical package management tool
Fedora Account System Username: timlau

Comment 1 Fedora Review Service 2025-04-25 09:06:14 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8966473
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2362270-yumex/fedora-rawhide-x86_64/08966473-yumex/fedora-review/review.txt

Found issues:

- Not a valid SPDX expression 'GPLv3+'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX.
  Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1
- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/yumex
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names
- Systemd user unit service file(s) in yumex-updater
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units
- icons in yumex, yumex-updater
- desktop file(s) with MimeType entry in yumex
  Read more: https://fedoraproject.org/w/index.php?title=Packaging:Scriptlets&oldid=494555#desktop-database

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Tim Lauridsen 2025-04-25 09:58:52 UTC

Spec URL: https://raw.githubusercontent.com/timlau/yumex-ng/refs/tags/fedora-review/yumex.spec
SRPM URL: https://github.com/timlau/yumex-ng/releases/download/fedora-review/yumex-5.2.0-2.fc42.src.rpm


Make license a valid SPDX expression

Comment 3 Fedora Review Service 2025-04-25 10:09:36 UTC

Created attachment 2087176 [details]
The .spec file difference from Copr build 8966473 to 8966615

Comment 4 Fedora Review Service 2025-04-25 10:09:38 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8966615
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2362270-yumex/fedora-rawhide-x86_64/08966615-yumex/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/yumex
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names
- Upstream MD5sum check error, diff is in /var/lib/copr-rpmbuild/results/yumex/diff.txt
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/
- Systemd user unit service file(s) in yumex-updater
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units
- icons in yumex, yumex-updater
- desktop file(s) with MimeType entry in yumex
  Read more: https://fedoraproject.org/w/index.php?title=Packaging:Scriptlets&oldid=494555#desktop-database

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Tim Lauridsen 2025-04-25 10:41:35 UTC

Spec URL: https://github.com/timlau/yumex-ng/releases/download/fedora-review/yumex.spec
SRPM URL: https://github.com/timlau/yumex-ng/releases/download/fedora-review/yumex-5.2.0-2.fc42.src.rpm

- removed update-desktop-database calls
- build SPRM with upstream sources, so MD5SUM will match
- the name should be ok, as this is an un-retirement of the old yumex package, that was maintained by me, back in the days

Comment 6 Fedora Review Service 2025-04-25 10:51:52 UTC

Created attachment 2087178 [details]
The .spec file difference from Copr build 8966615 to 8966667

Comment 7 Fedora Review Service 2025-04-25 10:51:54 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8966667
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2362270-yumex/fedora-rawhide-x86_64/08966667-yumex/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/yumex
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names
- Systemd user unit service file(s) in yumex-updater
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units
- icons in yumex, yumex-updater

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 8 Tim Lauridsen 2025-04-25 12:04:52 UTC

Spec URL: https://github.com/timlau/yumex-ng/releases/download/fedora-review/yumex.spec
SRPM URL: https://github.com/timlau/yumex-ng/releases/download/fedora-review/yumex-5.2.0-2.fc42.src.rpm

- cleanup systemd service scriptlets (https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units)
- cleanup icon handling (https://fedoraproject.org/w/index.php?title=Packaging:Scriptlets&oldid=494555#Icon_Cache)

Comment 9 Fedora Review Service 2025-04-25 12:15:21 UTC

Created attachment 2087190 [details]
The .spec file difference from Copr build 8966667 to 8967061

Comment 10 Fedora Review Service 2025-04-25 12:15:23 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8967061
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2362270-yumex/fedora-rawhide-x86_64/08967061-yumex/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/yumex
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names
- Systemd user unit service file(s) in yumex-updater
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units
- icons in yumex, yumex-updater

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 11 Tim Lauridsen 2025-04-25 12:25:41 UTC

Spec URL: https://github.com/timlau/yumex-ng/releases/download/fedora-review/yumex.spec
SRPM URL: https://github.com/timlau/yumex-ng/releases/download/fedora-review/yumex-5.2.0-2.fc42.src.rpm

- Removed calls to gtk-update-icon-cache from %posttrans

Comment 12 Fedora Review Service 2025-04-25 12:36:05 UTC

Created attachment 2087192 [details]
The .spec file difference from Copr build 8967061 to 8967105

Comment 13 Fedora Review Service 2025-04-25 12:36:07 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8967105
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2362270-yumex/fedora-rawhide-x86_64/08967105-yumex/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/yumex
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names
- Systemd user unit service file(s) in yumex-updater
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 14 Tim Lauridsen 2025-04-25 13:47:13 UTC

Spec URL: https://github.com/timlau/yumex-ng/releases/download/fedora-review/yumex.spec
SRPM URL: https://github.com/timlau/yumex-ng/releases/download/fedora-review/yumex-5.2.0-2.fc42.src.rpm

- fix ownership for /usr/share/yumex

Comment 15 Fedora Review Service 2025-04-25 14:09:33 UTC

Created attachment 2087232 [details]
The .spec file difference from Copr build 8967105 to 8967335

Comment 16 Fedora Review Service 2025-04-25 14:09:36 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8967335
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2362270-yumex/fedora-rawhide-x86_64/08967335-yumex/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/yumex
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names
- Systemd user unit service file(s) in yumex-updater
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 17 Neal Gompa 2025-04-25 22:35:44 UTC

Taking this review.

Comment 18 Tim Lauridsen 2025-04-27 16:37:39 UTC

Spec URL: https://github.com/timlau/yumex-ng/releases/download/fedora-review/yumex.spec
SRPM URL: https://github.com/timlau/yumex-ng/releases/download/fedora-review/yumex-5.2.0-1.fc42.src.rpm

- changed to use %autorelease & %autochangelog as preferred for new fedora packages.
- removed old obsoletes of yumex-dnf, not need as there is no relation or upgrade path from yumex-dnf to current yumex (both have been retired in Fedora for years)