Spec URL: https://raw.githubusercontent.com/timlau/yumex-ng/refs/heads/5.2.x/yumex.spec SRPM URL: https://github.com/timlau/yumex-ng/releases/download/yumex-5.2.0/yumex-5.2.0-1.fc42.src.rpm Description: Yum Extender graphical package management tool Fedora Account System Username: timlau
Copr build: https://copr.fedorainfracloud.org/coprs/build/8966473 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2362270-yumex/fedora-rawhide-x86_64/08966473-yumex/fedora-review/review.txt Found issues: - Not a valid SPDX expression 'GPLv3+'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/yumex Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names - Systemd user unit service file(s) in yumex-updater Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units - icons in yumex, yumex-updater - desktop file(s) with MimeType entry in yumex Read more: https://fedoraproject.org/w/index.php?title=Packaging:Scriptlets&oldid=494555#desktop-database Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://raw.githubusercontent.com/timlau/yumex-ng/refs/tags/fedora-review/yumex.spec SRPM URL: https://github.com/timlau/yumex-ng/releases/download/fedora-review/yumex-5.2.0-2.fc42.src.rpm Make license a valid SPDX expression
Created attachment 2087176 [details] The .spec file difference from Copr build 8966473 to 8966615
Copr build: https://copr.fedorainfracloud.org/coprs/build/8966615 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2362270-yumex/fedora-rawhide-x86_64/08966615-yumex/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/yumex Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names - Upstream MD5sum check error, diff is in /var/lib/copr-rpmbuild/results/yumex/diff.txt Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ - Systemd user unit service file(s) in yumex-updater Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units - icons in yumex, yumex-updater - desktop file(s) with MimeType entry in yumex Read more: https://fedoraproject.org/w/index.php?title=Packaging:Scriptlets&oldid=494555#desktop-database Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://github.com/timlau/yumex-ng/releases/download/fedora-review/yumex.spec SRPM URL: https://github.com/timlau/yumex-ng/releases/download/fedora-review/yumex-5.2.0-2.fc42.src.rpm - removed update-desktop-database calls - build SPRM with upstream sources, so MD5SUM will match - the name should be ok, as this is an un-retirement of the old yumex package, that was maintained by me, back in the days
Created attachment 2087178 [details] The .spec file difference from Copr build 8966615 to 8966667
Copr build: https://copr.fedorainfracloud.org/coprs/build/8966667 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2362270-yumex/fedora-rawhide-x86_64/08966667-yumex/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/yumex Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names - Systemd user unit service file(s) in yumex-updater Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units - icons in yumex, yumex-updater Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://github.com/timlau/yumex-ng/releases/download/fedora-review/yumex.spec SRPM URL: https://github.com/timlau/yumex-ng/releases/download/fedora-review/yumex-5.2.0-2.fc42.src.rpm - cleanup systemd service scriptlets (https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units) - cleanup icon handling (https://fedoraproject.org/w/index.php?title=Packaging:Scriptlets&oldid=494555#Icon_Cache)
Created attachment 2087190 [details] The .spec file difference from Copr build 8966667 to 8967061
Copr build: https://copr.fedorainfracloud.org/coprs/build/8967061 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2362270-yumex/fedora-rawhide-x86_64/08967061-yumex/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/yumex Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names - Systemd user unit service file(s) in yumex-updater Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units - icons in yumex, yumex-updater Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://github.com/timlau/yumex-ng/releases/download/fedora-review/yumex.spec SRPM URL: https://github.com/timlau/yumex-ng/releases/download/fedora-review/yumex-5.2.0-2.fc42.src.rpm - Removed calls to gtk-update-icon-cache from %posttrans
Created attachment 2087192 [details] The .spec file difference from Copr build 8967061 to 8967105
Copr build: https://copr.fedorainfracloud.org/coprs/build/8967105 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2362270-yumex/fedora-rawhide-x86_64/08967105-yumex/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/yumex Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names - Systemd user unit service file(s) in yumex-updater Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://github.com/timlau/yumex-ng/releases/download/fedora-review/yumex.spec SRPM URL: https://github.com/timlau/yumex-ng/releases/download/fedora-review/yumex-5.2.0-2.fc42.src.rpm - fix ownership for /usr/share/yumex
Created attachment 2087232 [details] The .spec file difference from Copr build 8967105 to 8967335
Copr build: https://copr.fedorainfracloud.org/coprs/build/8967335 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2362270-yumex/fedora-rawhide-x86_64/08967335-yumex/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/yumex Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names - Systemd user unit service file(s) in yumex-updater Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Taking this review.
Spec URL: https://github.com/timlau/yumex-ng/releases/download/fedora-review/yumex.spec SRPM URL: https://github.com/timlau/yumex-ng/releases/download/fedora-review/yumex-5.2.0-1.fc42.src.rpm - changed to use %autorelease & %autochangelog as preferred for new fedora packages. - removed old obsoletes of yumex-dnf, not need as there is no relation or upgrade path from yumex-dnf to current yumex (both have been retired in Fedora for years)