Bug 2364713

Summary: Review Request: rust-virtue - Sinless derive macro helper
Product: [Fedora] Fedora Reporter: Fabio Valentini <decathorpe>
Component: Package ReviewAssignee: fedora.dm0
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: fedora.dm0, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: fedora.dm0: fedora-review+
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/virtue
Whiteboard:
Fixed In Version: Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-05-12 12:14:23 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2364714    

Description Fabio Valentini 2025-05-07 14:32:44 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-virtue.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-virtue-0.0.18-1.fc42.src.rpm

Description:
A sinless derive macro helper.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2025-05-07 14:32:47 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=132427870

Comment 2 Fedora Review Service 2025-05-07 14:38:28 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9007711
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2364713-rust-virtue/fedora-rawhide-x86_64/09007711-rust-virtue/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 fedora.dm0 2025-05-07 22:34:38 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 4 Fabio Valentini 2025-05-08 10:30:10 UTC
Thank you for the review!

Comment 5 Fedora Admin user for bugzilla script actions 2025-05-08 10:30:44 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-virtue

Comment 6 Fedora Update System 2025-05-12 12:11:40 UTC
FEDORA-2025-d98b57ac52 (firecracker-1.12.0-1.fc43, rust-bincode1-1.3.3-1.fc43, and 6 more) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-d98b57ac52

Comment 7 Fedora Update System 2025-05-12 12:14:23 UTC
FEDORA-2025-d98b57ac52 (firecracker-1.12.0-1.fc43, rust-bincode1-1.3.3-1.fc43, and 6 more) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.