Bug 2364714 - Review Request: rust-bincode_derive - Implementation of #[derive(Encode, Decode)] for bincode
Summary: Review Request: rust-bincode_derive - Implementation of #[derive(Encode, Deco...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: fedora.dm0
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/bincode_derive
Whiteboard:
Depends On: 2364713
Blocks: 2350432
TreeView+ depends on / blocked
 
Reported: 2025-05-07 14:33 UTC by Fabio Valentini
Modified: 2025-05-12 12:14 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-05-12 12:14:27 UTC
Type: ---
Embargoed:
fedora.dm0: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2025-05-07 14:33:26 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-bincode_derive.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-bincode_derive-2.0.1-1.fc42.src.rpm

Description:
Implementation of #[derive(Encode, Decode)] for bincode.

Fedora Account System Username: decathorpe

Comment 1 Fedora Review Service 2025-05-07 14:36:17 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9007712
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2364714-rust-bincode_derive/fedora-rawhide-x86_64/09007712-rust-bincode_derive/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 fedora.dm0 2025-05-07 22:45:09 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass (no upstream tests)
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 3 Fabio Valentini 2025-05-08 10:30:17 UTC
Thank you for the review!

Comment 4 Fedora Admin user for bugzilla script actions 2025-05-08 10:32:13 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-bincode_derive

Comment 5 Fedora Update System 2025-05-12 12:11:43 UTC
FEDORA-2025-d98b57ac52 (firecracker-1.12.0-1.fc43, rust-bincode1-1.3.3-1.fc43, and 6 more) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-d98b57ac52

Comment 6 Fedora Update System 2025-05-12 12:14:27 UTC
FEDORA-2025-d98b57ac52 (firecracker-1.12.0-1.fc43, rust-bincode1-1.3.3-1.fc43, and 6 more) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.