Bug 2365475
| Summary: | Review Request: rust-deadpool - Dead simple async pool | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ben Beasley <code> | ||||||||
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | rawhide | CC: | decathorpe, package-review | ||||||||
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| URL: | https://crates.io/crates/deadpool | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | --- | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2025-05-13 11:41:10 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | 2365474 | ||||||||||
| Bug Blocks: | 2365476 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Ben Beasley
2025-05-11 00:51:55 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/9017587 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2365475-rust-deadpool/fedora-rawhide-x86_64/09017587-rust-deadpool/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Copr build: https://copr.fedorainfracloud.org/coprs/build/9017586 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2365475-rust-deadpool/fedora-rawhide-x86_64/09017586-rust-deadpool/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package looks good to me, two minor things: - The /test-build.sh file causes a dependency on /bin/bash to get generated, please exclude it from the built package. - The "config" dependency is used for one single test file (tests/managed_config.rs), it could be dropped entirely if that test file is dropped too - but that's up to you. The current patch is OK too, of course. (In reply to Fabio Valentini from comment #3) > Package looks good to me, two minor things: > > - The /test-build.sh file causes a dependency on /bin/bash to get generated, > please exclude it from the built package. Fixing and preparing an updated submission, thanks. > - The "config" dependency is used for one single test file > (tests/managed_config.rs), it could be dropped entirely if that test file is > dropped too - but that's up to you. The current patch is OK too, of course. Hmm. It turns out that the test file in question starts with #![cfg(all(feature = "managed", feature = "serde"))] and serde is not a default feature, so the test isn’t even being run. I can therefore drop the config dev-dependency without even having to remove the test file or patch out the reference to it in Cargo.toml. I’ll do that. New Spec URL: https://music.fedorapeople.org/20250512/rust-deadpool.spec New SRPM URL: https://music.fedorapeople.org/20250512/rust-deadpool-0.12.2-1.fc42.src.rpm Created attachment 2089549 [details]
Updated configuration file for rust2rpm
Oops! I didn’t actually exclude the shell script! One more update coming… Created attachment 2089550 [details]
The .spec file difference from Copr build 9017587 to 9024912
Copr build: https://copr.fedorainfracloud.org/coprs/build/9024912 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2365475-rust-deadpool/fedora-rawhide-x86_64/09024912-rust-deadpool/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. New Spec URL: https://music.fedorapeople.org/20250512-v2/rust-deadpool.spec New SRPM URL: https://music.fedorapeople.org/20250512-v2/rust-deadpool-0.12.2-1.fc42.src.rpm https://release-monitoring.org/project/378103/ Copr build: https://copr.fedorainfracloud.org/coprs/build/9024935 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2365475-rust-deadpool/fedora-rawhide-x86_64/09024935-rust-deadpool/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Thanks, looks good to me now! === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional) Thank you for the review! FEDORA-2025-2a5b26c2ba (rust-deadpool-0.12.2-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-2a5b26c2ba FEDORA-2025-2a5b26c2ba (rust-deadpool-0.12.2-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-94751acc27 (rust-deadpool-0.12.2-1.fc42, rust-deadpool-runtime-0.1.4-1.fc42, and 2 more) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-94751acc27 FEDORA-2025-2e896437ac (rust-deadpool-0.12.2-1.fc41, rust-deadpool-runtime-0.1.4-1.fc41, and 2 more) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-2e896437ac FEDORA-EPEL-2025-56b8dc7eac (rust-actix-macros-0.2.4-4.el10_1, rust-actix-rt-2.10.0-3.el10_1, and 5 more) has been submitted as an update to Fedora EPEL 10.1. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-56b8dc7eac FEDORA-2025-94751acc27 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-94751acc27` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-94751acc27 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-2e896437ac has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-2e896437ac` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-2e896437ac See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2025-56b8dc7eac has been pushed to the Fedora EPEL 10.1 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-56b8dc7eac See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2025-56b8dc7eac has been pushed to the Fedora EPEL 10.1 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-56b8dc7eac See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-94751acc27 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-94751acc27` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-94751acc27 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-2e896437ac has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-2e896437ac` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-2e896437ac See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-94751acc27 (rust-deadpool-0.12.2-1.fc42, rust-deadpool-runtime-0.1.4-1.fc42, and 6 more) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2025-56b8dc7eac (rust-actix-macros-0.2.4-4.el10_1, rust-actix-rt-2.10.0-3.el10_1, and 7 more) has been pushed to the Fedora EPEL 10.1 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-2e896437ac (rust-deadpool-0.12.2-1.fc41, rust-deadpool-runtime-0.1.4-1.fc41, and 6 more) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. |