Bug 2365476 - Review Request: rust-wiremock - HTTP mocking to test Rust applications
Summary: Review Request: rust-wiremock - HTTP mocking to test Rust applications
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/wiremock
Whiteboard:
Depends On: 2365475
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-05-11 00:57 UTC by Ben Beasley
Modified: 2025-05-27 02:05 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-05-13 12:26:10 UTC
Type: Bug
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)
Configuration file for rust2rpm (1.10 KB, text/plain)
2025-05-11 00:57 UTC, Ben Beasley
no flags Details

Description Ben Beasley 2025-05-11 00:57:52 UTC
Created attachment 2089319 [details]
Configuration file for rust2rpm

Spec URL: https://music.fedorapeople.org/rust-wiremock.spec
SRPM URL: https://music.fedorapeople.org/rust-wiremock-0.6.3-1.fc42.src.rpm
Description: HTTP mocking to test Rust applications.
Fedora Account System Username: music

This would enable additional tests in rust-reqwest-retry and in uv, and would save the effort of patching out a gradually-increasing number of tests in uv that use wiremock.

A COPR build with fedora-review enabled is available at: https://copr.fedorainfracloud.org/coprs/music/wiremock/build/9017568/

I built https://src.fedoraproject.org/rpms/rust-reqwest-retry/pull-request/2 in https://copr.fedorainfracloud.org/coprs/music/wiremock/build/9017589/ to demonstrate that this package is usable for running tests.

Comment 1 Fedora Review Service 2025-05-11 00:59:45 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9017591
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2365476-rust-wiremock/fedora-rawhide-x86_64/09017591-rust-wiremock/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fedora Review Service 2025-05-11 00:59:49 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9017590
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2365476-rust-wiremock/fedora-rawhide-x86_64/09017590-rust-wiremock/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fabio Valentini 2025-05-12 16:26:02 UTC
Package was generated with rust2rpm, simplifying the review.

Patches are documented and reasonable, and were either submitted as Pull Requests, or are not (easily) upstreamable - i.e. dropping the unmaintained "surf" HTTP client and async-std would require rewriting a lot of tests and documentation code.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
   (some tests dropped as they depend on unmaintained dependencies)
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

I trust you to only import this package after #2365475 is approved and reviewed too :)

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

Comment 4 Ben Beasley 2025-05-12 18:27:15 UTC
Thank you for the review! I will go ahead and prepare the repository, and will proceed with importing and building after bug 2365475 is complete.

https://release-monitoring.org/project/378105/

Comment 5 Fedora Admin user for bugzilla script actions 2025-05-12 18:27:50 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-wiremock

Comment 6 Fedora Update System 2025-05-13 12:21:17 UTC
FEDORA-2025-f4a4ce63d6 (rust-wiremock-0.6.3-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-f4a4ce63d6

Comment 7 Fedora Update System 2025-05-13 12:26:10 UTC
FEDORA-2025-f4a4ce63d6 (rust-wiremock-0.6.3-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2025-05-14 02:10:41 UTC
FEDORA-2025-94751acc27 (rust-deadpool-0.12.2-1.fc42, rust-deadpool-runtime-0.1.4-1.fc42, and 2 more) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-94751acc27

Comment 9 Fedora Update System 2025-05-14 02:10:43 UTC
FEDORA-2025-2e896437ac (rust-deadpool-0.12.2-1.fc41, rust-deadpool-runtime-0.1.4-1.fc41, and 2 more) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-2e896437ac

Comment 10 Fedora Update System 2025-05-14 10:45:09 UTC
FEDORA-EPEL-2025-56b8dc7eac (rust-actix-macros-0.2.4-4.el10_1, rust-actix-rt-2.10.0-3.el10_1, and 5 more) has been submitted as an update to Fedora EPEL 10.1.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-56b8dc7eac

Comment 11 Fedora Update System 2025-05-15 01:24:08 UTC
FEDORA-2025-94751acc27 has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-94751acc27`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-94751acc27

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2025-05-15 02:35:37 UTC
FEDORA-2025-2e896437ac has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-2e896437ac`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-2e896437ac

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2025-05-15 02:47:04 UTC
FEDORA-EPEL-2025-56b8dc7eac has been pushed to the Fedora EPEL 10.1 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-56b8dc7eac

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2025-05-19 02:04:17 UTC
FEDORA-EPEL-2025-56b8dc7eac has been pushed to the Fedora EPEL 10.1 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-56b8dc7eac

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2025-05-19 02:27:10 UTC
FEDORA-2025-94751acc27 has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-94751acc27`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-94751acc27

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Fedora Update System 2025-05-19 02:41:40 UTC
FEDORA-2025-2e896437ac has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-2e896437ac`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-2e896437ac

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2025-05-27 01:26:12 UTC
FEDORA-2025-94751acc27 (rust-deadpool-0.12.2-1.fc42, rust-deadpool-runtime-0.1.4-1.fc42, and 6 more) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 18 Fedora Update System 2025-05-27 01:41:10 UTC
FEDORA-EPEL-2025-56b8dc7eac (rust-actix-macros-0.2.4-4.el10_1, rust-actix-rt-2.10.0-3.el10_1, and 7 more) has been pushed to the Fedora EPEL 10.1 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 19 Fedora Update System 2025-05-27 02:05:19 UTC
FEDORA-2025-2e896437ac (rust-deadpool-0.12.2-1.fc41, rust-deadpool-runtime-0.1.4-1.fc41, and 6 more) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.