Bug 2365763
| Summary: | Review Request: lf - Terminal file manager | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | me <me> | ||||
| Component: | Package Review | Assignee: | Mikel Olasagasti Uranga <mikel> | ||||
| Status: | ASSIGNED --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | mikel, package-review | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | --- | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | Type: | --- | |||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 2365761 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
me@pennbauman.com
2025-05-12 22:24:33 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/9025547 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2365763-lf/fedora-rawhide-x86_64/09025547-lf/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. > %global common_description %{expand: > Terminal file manager.} Description should be a bit more... descriptive. > %generate_buildrequires > %go_generate_buildrequires Go-SIG will propose to make vendored builds the default option using go-vendor-tools for Fedora 43. lf's dependency stack is small, but I would recommend to adopt the new format to make things simpler for you. You can generate the new spec with `go2rpm -p vendor github.com/gokcehan/lf` and you can check examples like helm or opentofu packages to see how it works. I would recommend to join Go-SIG's Matrix channel for more guidance if required: https://matrix.to/#/#golang:fedoraproject.org If you prefer to keep the old method I can review the dependency as well. > install -m 0644 -Dvp etc/%{name}.zsh %{buildroot}%{_datadir}/zsh/site-functions/_%{name} > install -m 0644 -Dvp etc/%{name}.fish %{buildroot}%{_datadir}/fish/vendor_completions.d/%{name}.fish You can use %{fish_completions_dir}/%{name}.fish and %{zsh_completions_dir}/_%{name} as you do with %{bash_completions_dir} I've updated the description and the macro usage. I've got vendoring working locally, but I don't think I can have it work on Copr without uploading the lf-r35-vendor.tar.bz2 file to the lookaside cache. If you want to upload that (and the regular regular source tarball) to the cache, I could setup vendoring and also add a sources file. Updated src.rpm and spec SRPM URL: https://download.copr.fedorainfracloud.org/results/pennbauman/ports/srpm-builds/09052967/lf-r35-1.src.rpm Spec URL: https://download.copr.fedorainfracloud.org/results/pennbauman/ports/srpm-builds/09052967/lf.spec Created attachment 2090045 [details]
The .spec file difference from Copr build 9025547 to 9052994
Copr build: https://copr.fedorainfracloud.org/coprs/build/9052994 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2365763-lf/fedora-rawhide-x86_64/09052994-lf/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. |