Bug 2366623

Summary: Review Request: rust-potential_utf - Unvalidated string and character types
Product: [Fedora] Fedora Reporter: Ben Beasley <code>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/potential_utf
Whiteboard:
Fixed In Version: Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2026-03-14 16:20:52 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2366675    
Attachments:
Description Flags
Configuration file for rust2rpm
none
Configuration file for rust2rpm none

Description Ben Beasley 2025-05-15 17:17:11 UTC
Created attachment 2089980 [details]
Configuration file for rust2rpm

Spec URL: https://music.fedorapeople.org/rust-potential_utf.spec
SRPM URL: https://music.fedorapeople.org/rust-potential_utf-0.1.2-1.fc42.src.rpm
Description: Unvalidated string and character types.
Fedora Account System Username: music

This will be part of the ICU4X 2.0 stack update; see https://src.fedoraproject.org/rpms/rust-idna_adapter/pull-request/1. Unfortunately, it can’t be built for Rawhide until that update is already happening in a side tag, but I did build this in COPR with fedora-review enabled: https://copr.fedorainfracloud.org/coprs/music/icu4x/build/9050899/

Comment 1 Fedora Review Service 2025-05-15 17:21:54 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9050980
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2366623-rust-potential_utf/fedora-rawhide-x86_64/09050980-rust-potential_utf/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fedora Review Service 2025-05-15 17:22:22 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9050981
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2366623-rust-potential_utf/fedora-rawhide-x86_64/09050981-rust-potential_utf/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Ben Beasley 2025-05-15 20:12:31 UTC
Created attachment 2090008 [details]
Configuration file for rust2rpm

Comment 4 Fabio Valentini 2025-05-17 21:15:39 UTC
Review based on the spec file and build from the linked COPR.

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

Comment 5 Ben Beasley 2025-05-18 00:53:52 UTC
Thank you for the review!

https://release-monitoring.org/project/378232/

Comment 6 Fedora Admin user for bugzilla script actions 2025-05-18 00:54:31 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-potential_utf

Comment 8 Fabio Valentini 2026-03-14 16:20:52 UTC
This has long been imported and built:
https://src.fedoraproject.org/rpms/rust-potential_utf