Created attachment 2090009 [details] Configuration file for rust2rpm Spec URL: https://music.fedorapeople.org/rust-icu_locale_core.spec SRPM URL: https://music.fedorapeople.org/rust-potential_utf-0.1.2-1.fc42.src.rpm Description: API for managing Unicode Language and Locale Identifiers. Fedora Account System Username: music This will be part of the ICU4X 2.0 stack update; see https://src.fedoraproject.org/rpms/rust-idna_adapter/pull-request/1. Unfortunately, it can’t be built for Rawhide until that update is already happening in a side tag, but I did build this in COPR with fedora-review enabled: https://copr.fedorainfracloud.org/coprs/music/icu4x/build/9052175/
Cannot find any valid SRPM URL for this ticket. Common causes are: - You didn't specify `SRPM URL: ...` in the ticket description or any of your comments - The URL schema isn't HTTP or HTTPS - The SRPM package linked in your URL doesn't match the package name specified in the ticket summary --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Correction: Spec URL: https://music.fedorapeople.org/rust-icu_locale_core.spec SRPM URL: https://music.fedorapeople.org/rust-icu_locale_core-2.0.0-1.fc42.src.rpm Also, there’s a test failure on i686: ---- locale::test_sizes stdout ---- thread 'locale::test_sizes' panicked at src/locale.rs:107:5: assertion `left == right` failed left: 12 right: 16 It’s obvious that this is just a 64-bit assumption; I’ll patch it and follow up with an updated submission.
Copr build: https://copr.fedorainfracloud.org/coprs/build/9052201 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2366675-rust-icu_locale_core/fedora-rawhide-x86_64/09052201-rust-icu_locale_core/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Fixed the test failure via and re-uploaded to the same URLs: Spec URL: https://music.fedorapeople.org/rust-icu_locale_core.spec SRPM URL: https://music.fedorapeople.org/rust-icu_locale_core-2.0.0-1.fc42.src.rpm New COPR build with fedora-review enabled: https://copr.fedorainfracloud.org/coprs/music/icu4x/build/9052695/
Copr build: https://copr.fedorainfracloud.org/coprs/build/9052701 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2366675-rust-icu_locale_core/fedora-rawhide-x86_64/09052701-rust-icu_locale_core/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Created attachment 2090042 [details] Updated configuration file for rust2rpm
Review based on the spec file and build from the linked COPR. === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional) === Consider dropping the JSON files (only used as test and benchmark input data) from the built packages, but this is not a requirement since they're not unusually large compared to the source code itself.
Thank you for the review! https://release-monitoring.org/project/378234/
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-icu_locale_core
https://src.fedoraproject.org/rpms/rust-icu_locale_core/pull-request/1
This has long been imported and built: https://src.fedoraproject.org/rpms/rust-icu_locale_core