Bug 2368933

spec sanity:

 1. %autorelease is the recommended way now, consider switching to it
 2. the description line is too long and rpmlint will complain about it
 3. upstream sues pytest to run the tests -- can this be done in %check? and if no, please add a comment that explains why
 4. I see no manual %license file in %files, in that case, please add -l to %pyproject_save_files to assert at least one license file is installed

Overall, the spec is nice and tidy, no craziness.

s/sues/uses/

Spec URL: https://download.copr.fedorainfracloud.org/results/frostyx/python-dbus-fast/fedora-rawhide-x86_64/09095632-python-dbus-fast/python-dbus-fast.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/frostyx/python-dbus-fast/fedora-rawhide-x86_64/09095632-python-dbus-fast/python-dbus-fast-2.44.1-1.fc43.src.rpm

# Upstream repository has a tests directory using pytest. Unfortunately it is
# not shipped in the PyPI tarball, so we can't run the tests here.

Please see https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_source_files_from_pypi

> Packages MAY use sources from PyPI.
> 
> However, packages SHOULD NOT use an archive that omits test suites,
> licenses and/or documentation present in other source archives.

Spec URL: https://download.copr.fedorainfracloud.org/results/frostyx/python-dbus-fast/fedora-rawhide-x86_64/09098119-python-dbus-fast/python-dbus-fast.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/frostyx/python-dbus-fast/fedora-rawhide-x86_64/09098119-python-dbus-fast/python-dbus-fast-2.44.1-1.fc43.src.rpm

> %pyproject_buildrequires -x tool.poetry.group.dev.dependencies

The -x option seems like a leftover from your testing, there is no such extra. Unfortunately, the -x option currently has no validation (see bz2360766), so it does nothing.

> BuildRequires: python3-pytest-cov

This shouldn't be needed, but perhaps it's easier to have it and pass --no-cov to pytest than sedding the pytest options from pyproject.toml. I leave this up to you.

> -v -Wdefault

Isn't this already set in the config? Does it need repeating?

Spec URL: https://download.copr.fedorainfracloud.org/results/frostyx/python-dbus-fast/fedora-rawhide-x86_64/09098333-python-dbus-fast/python-dbus-fast.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/frostyx/python-dbus-fast/fedora-rawhide-x86_64/09098333-python-dbus-fast/python-dbus-fast-2.44.1-1.fc43.src.rpm

Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

python3-dbus-fast.x86_64: E: spelling-error ('performant', '%description -l en_US performant -> perform ant, perform-ant, performance')
python3-dbus-fast.x86_64: W: no-documentation
 1 packages and 0 specfiles checked; 1 errors, 1 warnings, 3 filtered, 1 badness; has taken 0.6 s 



Is there a README to be added as doc?

Package approved.

Please consider adding

   %doc README.md CHANGELOG.md

when importing it.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


===== MUST items =====

C/C++:
[-]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files are Python extension modules.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "MIT License". 148 files have unknown
     license.
     $ askalono identify LICENSE 
     License: MIT (original text)
     Score: 0.994
[x]: Package must own all directories that it creates.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries or specifies bundled libraries
     with Provides: bundled(<libname>) if unbundling is not possible.
[-]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[?]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python3-dbus-fast-2.44.1-1.fc43.x86_64.rpm
          python-dbus-fast-2.44.1-1.fc43.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpa8dixrfn')]
checks: 32, packages: 2

python-dbus-fast.src: E: spelling-error ('performant', '%description -l en_US performant -> perform ant, perform-ant, performance')
python3-dbus-fast.x86_64: E: spelling-error ('performant', '%description -l en_US performant -> perform ant, perform-ant, performance')
python3-dbus-fast.x86_64: W: no-documentation
 2 packages and 0 specfiles checked; 2 errors, 1 warnings, 7 filtered, 2 badness; has taken 1.0 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

python3-dbus-fast.x86_64: E: spelling-error ('performant', '%description -l en_US performant -> perform ant, perform-ant, performance')
python3-dbus-fast.x86_64: W: no-documentation
 1 packages and 0 specfiles checked; 1 errors, 1 warnings, 3 filtered, 1 badness; has taken 0.6 s 



Unversioned so-files
--------------------
python3-dbus-fast: /usr/lib64/python3.13/site-packages/dbus_fast/_private/address.cpython-313-x86_64-linux-gnu.so
python3-dbus-fast: /usr/lib64/python3.13/site-packages/dbus_fast/_private/marshaller.cpython-313-x86_64-linux-gnu.so
python3-dbus-fast: /usr/lib64/python3.13/site-packages/dbus_fast/_private/unmarshaller.cpython-313-x86_64-linux-gnu.so
python3-dbus-fast: /usr/lib64/python3.13/site-packages/dbus_fast/aio/message_reader.cpython-313-x86_64-linux-gnu.so
python3-dbus-fast: /usr/lib64/python3.13/site-packages/dbus_fast/message.cpython-313-x86_64-linux-gnu.so
python3-dbus-fast: /usr/lib64/python3.13/site-packages/dbus_fast/message_bus.cpython-313-x86_64-linux-gnu.so
python3-dbus-fast: /usr/lib64/python3.13/site-packages/dbus_fast/service.cpython-313-x86_64-linux-gnu.so
python3-dbus-fast: /usr/lib64/python3.13/site-packages/dbus_fast/signature.cpython-313-x86_64-linux-gnu.so
python3-dbus-fast: /usr/lib64/python3.13/site-packages/dbus_fast/unpack.cpython-313-x86_64-linux-gnu.so

Source checksums
----------------
https://github.com/bluetooth-devices/dbus-fast/archive/v2.44.1/python-dbus-fast-2.44.1.tar.gz :
  CHECKSUM(SHA256) this package     : 1f25e21eb7c6f771b53e45caba9ea7ecd640b3d39fb1cb68b3cdc8bc8f9bc002
  CHECKSUM(SHA256) upstream package : 1f25e21eb7c6f771b53e45caba9ea7ecd640b3d39fb1cb68b3cdc8bc8f9bc002


BuildRequires
-------------

    (python3dist(cython) < 3.1~~ with python3dist(cython) >= 3)
    (python3dist(tomli) if python3-devel < 3.11)
    /usr/bin/dbus-run-session
    gcc
    pyproject-rpm-macros
    python3-cairo
    python3-devel
    python3-gobject
    python3-pytest
    python3-pytest-asyncio
    python3-pytest-cov
    python3dist(packaging)
    python3dist(pip) >= 19
    python3dist(poetry-core) >= 1
    python3dist(setuptools) >= 65.4.1
    python3dist(wheel)


Requires
--------
python3-dbus-fast (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    python(abi) = 3.13
    rtld(GNU_HASH)



Provides
--------
python3-dbus-fast:
    python-dbus-fast = 2.44.1-1.fc43
    python3-dbus-fast = 2.44.1-1.fc43
    python3-dbus-fast(x86-64) = 2.44.1-1.fc43
    python3.13-dbus-fast = 2.44.1-1.fc43
    python3.13dist(dbus-fast) = 2.44.1
    python3dist(dbus-fast) = 2.44.1


Generated by fedora-review 0.7.0 (fed5495) last change: 2019-03-17
Command line :try-fedora-review -b 2368933 -m fedora-rawhide-x86_64 -o=--enablerepo=local
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: R, Java, fonts, Haskell, Ruby, Ocaml, C/C++, Perl, SugarActivity, PHP
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

The Pagure repository was created at https://src.fedoraproject.org/rpms/python-dbus-fast

> Package approved.

Thank you very much for reviewing the package Miro

> Please consider adding
>   %doc README.md CHANGELOG.md

Done

FEDORA-2025-c4b29000bb (python-dbus-fast-2.44.1-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-c4b29000bb

FEDORA-2025-626ea82c0f (python-dbus-fast-2.44.1-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-626ea82c0f

FEDORA-2025-626ea82c0f has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-626ea82c0f \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-626ea82c0f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2025-c4b29000bb has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-c4b29000bb \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-c4b29000bb

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2025-626ea82c0f (python-dbus-fast-2.44.1-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2025-c4b29000bb (python-dbus-fast-2.44.1-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.