Bug 2369671

Summary:	Review Request: atkinson-hyperlegible-next-fonts - Monospaced typeface made for legibility and comprehension with low-vision
Product:	[Fedora] Fedora	Reporter:	Julius Enriquez <jce>
Component:	Package Review	Assignee:	Benson Muite <benson_muite>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	benson_muite, johnh, package-review
Target Milestone:	---	Flags:	benson_muite: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
URL:	https://www.brailleinstitute.org/freefont/
Whiteboard:
Fixed In Version:		Doc Type:	---
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2025-12-18 09:44:24 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Julius Enriquez 2025-06-02 00:39:23 UTC

Spec URL: https://download.copr.fedorainfracloud.org/results/julicen/atkinson-hyperlegible-fonts/srpm-builds/09109171/atkinson-hyperlegible-next.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/julicen/atkinson-hyperlegible-fonts/srpm-builds/09109171/atkinson-hyperlegible-next-fonts-1.0.0-1.fc42.src.rpm
Description:
Atkinson Hyperlegible is a uniquely accessible typeface created by Braille
Institute of America. It has been developed specifically to increase legibility
for readers with low vision, and to improve comprehension.

Atkinson Hyperlegible Next, a refined version of Atkinson Hyperlegible,
improves on the original in every way. It features new weights, improved
kerning, refined curves, added symbols, and additional language support.
Fedora Account System Username: julicen

This creates packages for Atkinson Hyperlegible Next, the second iteration of Atkinson Hyperlegible typeface. This font family is designed with maximised legibility and readability in mind for people with low-vision.

Koji build task:
https://koji.fedoraproject.org/koji/taskinfo?taskID=133442399

Related to this request for Atkinson Hyperlegible Mono:
https://bugzilla.redhat.com/show_bug.cgi?id=2369670

This will be one of my first packages, so a sponsor is needed.

Comment 1 Fedora Review Service 2025-06-02 09:02:19 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/9110220
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2369671-atkinson-hyperlegible-next/fedora-rawhide-x86_64/09110220-atkinson-hyperlegible-next-fonts/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Benson Muite 2025-06-02 09:17:10 UTC

Thanks for bringing this to Fedora.  Quick comments:
a) Consider using %autorelease and %autochangelog macros
b) The name should end with fonts, see the packaging guidelines
c) Webfonts are typically not packaged, see the packaging guidelines
d) %defattr(0644,root,root,-) is typically not required
https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/

Comment 3 Julius Enriquez 2025-06-03 04:20:35 UTC

Updated SPEC URL: https://download.copr.fedorainfracloud.org/results/julicen/atkinson-hyperlegible-fonts/fedora-rawhide-x86_64/09116354-atkinson-hyperlegible-next-fonts/atkinson-hyperlegible-next-fonts.spec
Updated SRPM URL: https://download.copr.fedorainfracloud.org/results/julicen/atkinson-hyperlegible-fonts/fedora-rawhide-x86_64/09116354-atkinson-hyperlegible-next-fonts/atkinson-hyperlegible-next-fonts-2.100-1.fc43.src.rpm

Koji build task:
https://koji.fedoraproject.org/koji/taskinfo?taskID=133470585

I have updated the specfile with your suggested revisions, including a version number change to match what the source mentions in its README.

Comment 4 Fedora Review Service 2025-06-03 04:26:21 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/9120419
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2369671-atkinson-hyperlegible-next/fedora-rawhide-x86_64/09120419-atkinson-hyperlegible-next-fonts/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Julius Enriquez 2025-06-15 08:36:47 UTC

Asking for a follow-up to this review request.

Comment 6 Julius Enriquez 2025-07-08 06:24:19 UTC

Are there any further changes necessary?

Comment 7 Benson Muite 2025-07-24 06:42:36 UTC

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package does not contain duplicates in %files.
  Note: warning: File listed twice: /usr/share/doc/atkinson-hyperlegible-
  next-fonts-common/DESCRIPTION.en_us.html
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/#_duplicate_files


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[ ]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "SIL Open Font License 1.1", "*No
     copyright* SIL Open Font License 1.1". 50 files have unknown license.
     Detailed output of licensecheck in /home/fedora-packaging/reviews/atkinson-
     hyperlegible-next-fonts/2369671-atkinson-hyperlegible-next-
     fonts/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 903 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[-]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define autorelease(e:s:pb:n)
     %{?-p:0.}%{lua:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

fonts:
[!]: Run fc-query on all fonts in package.
     Note: Cannot find fc-query command, install fontconfig package to make
     a comprehensive font review.
     See: url: undefined
[!]: Run repo-font-audit on all fonts in package.
     Note: Cannot find repo-font-audit, install fontpackages-tools package
     to make a comprehensive font review.
     See: url: undefined


Rpmlint
-------
Checking: atkinson-hyperlegible-next-fonts-2.100-1.fc43.noarch.rpm
          atkinson-hyperlegible-next-fonts-common-2.100-1.fc43.noarch.rpm
          atkinson-hyperlegible-next-fonts-2.100-1.fc43.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpbfqw797v')]
checks: 32, packages: 3

atkinson-hyperlegible-next-fonts.noarch: E: spelling-error ('kerning', '%description -l en_US kerning -> keening, kenning, yearning')
atkinson-hyperlegible-next-fonts.src: E: spelling-error ('kerning', '%description -l en_US kerning -> keening, kenning, yearning')
atkinson-hyperlegible-next-fonts-common.noarch: E: spelling-error ('kerning', '%description -l en_US kerning -> keening, kenning, yearning')
atkinson-hyperlegible-next-fonts.spec:63: W: setup-not-quiet
atkinson-hyperlegible-next-fonts.noarch: W: no-documentation
atkinson-hyperlegible-next-fonts-common.noarch: E: description-line-too-long This package consists of files used by other atkinson-hyperlegible-next-fonts packages.
 3 packages and 0 specfiles checked; 4 errors, 2 warnings, 12 filtered, 4 badness; has taken 0.5 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 2

atkinson-hyperlegible-next-fonts-common.noarch: E: spelling-error ('kerning', '%description -l en_US kerning -> keening, kenning, yearning')
atkinson-hyperlegible-next-fonts.noarch: E: spelling-error ('kerning', '%description -l en_US kerning -> keening, kenning, yearning')
atkinson-hyperlegible-next-fonts.noarch: W: no-documentation
atkinson-hyperlegible-next-fonts-common.noarch: E: description-line-too-long This package consists of files used by other atkinson-hyperlegible-next-fonts packages.
 2 packages and 0 specfiles checked; 3 errors, 1 warnings, 8 filtered, 3 badness; has taken 0.1 s 



Source checksums
----------------
https://github.com/googlefonts/atkinson-hyperlegible-next/archive/7925f50.tar.gz :
  CHECKSUM(SHA256) this package     : 4b455dcf5ce2d6261df7caf6f4d035c893b446f14269106a07bc03c204368626
  CHECKSUM(SHA256) upstream package : 4b455dcf5ce2d6261df7caf6f4d035c893b446f14269106a07bc03c204368626


Requires
--------
atkinson-hyperlegible-next-fonts (rpmlib, GLIBC filtered):
    atkinson-hyperlegible-next-fonts-common
    config(atkinson-hyperlegible-next-fonts)

atkinson-hyperlegible-next-fonts-common (rpmlib, GLIBC filtered):
    fontpackages-filesystem



Provides
--------
atkinson-hyperlegible-next-fonts:
    atkinson-hyperlegible-next-fonts
    config(atkinson-hyperlegible-next-fonts)
    font(atkinsonhyperlegiblenext)
    font(atkinsonhyperlegiblenextextrabold)
    font(atkinsonhyperlegiblenextextralight)
    font(atkinsonhyperlegiblenextlight)
    font(atkinsonhyperlegiblenextmedium)
    font(atkinsonhyperlegiblenextsemibold)

atkinson-hyperlegible-next-fonts-common:
    atkinson-hyperlegible-next-fonts-common



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2369671
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic, fonts
Disabled plugins: PHP, Python, R, Java, C/C++, Haskell, SugarActivity, Perl, Ocaml
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comments:
a) Thanks for bringing this to Fedora, sorry for delay in reviewing.
b) The common package contains only one file? Why not just include it in the main package?
c) License file is not installed. See:
https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/#_spec_template_documentation
Can the %fontinstall and %fontbuild macros be used?

Comment 8 Julius Enriquez 2025-07-31 14:26:11 UTC

Updated SPEC URL: https://download.copr.fedorainfracloud.org/results/julicen/atkinson-hyperlegible-fonts/fedora-rawhide-x86_64/09359942-atkinson-hyperlegible-next-fonts/atkinson-hyperlegible-next-fonts.spec
Updated SRPM URL: https://download.copr.fedorainfracloud.org/results/julicen/atkinson-hyperlegible-fonts/fedora-rawhide-x86_64/09359942-atkinson-hyperlegible-next-fonts/atkinson-hyperlegible-next-fonts-2.100-1.fc43.src.rpm

Thanks for the feedback! The updated specfile has been refactored to be shorter by using more RPM macros, including the use of %fontinstall and %fontbuild. There is now only one package that includes the documentation and the license file.

Comment 9 Julius Enriquez 2025-08-01 10:09:17 UTC

Koji build task:
https://koji.fedoraproject.org/koji/taskinfo?taskID=135563986

Comment 10 Benson Muite 2025-08-02 18:49:04 UTC

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "SIL Open Font License 1.1", "*No
     copyright* SIL Open Font License 1.1". 50 files have unknown license.
     Detailed output of licensecheck in /home/fedora-
     packaging/reviews/atkinson-hyperlegible-next-fonts/2369671-atkinson-
     hyperlegible-next-fonts/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[-]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 903 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[ ]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define autorelease(e:s:pb:n)
     %{?-p:0.}%{lua:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

fonts:
[!]: Run fc-query on all fonts in package.
     Note: Cannot find fc-query command, install fontconfig package to make
     a comprehensive font review.
     See: url: undefined
[!]: Run repo-font-audit on all fonts in package.
     Note: Cannot find repo-font-audit, install fontpackages-tools package
     to make a comprehensive font review.
     See: url: undefined


Rpmlint
-------
Checking: atkinson-hyperlegible-next-fonts-2.100-1.fc43.noarch.rpm
          atkinson-hyperlegible-next-fonts-all-2.100-1.fc43.noarch.rpm
          atkinson-hyperlegible-next-fonts-2.100-1.fc43.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpk0bxqmzn')]
checks: 32, packages: 3

atkinson-hyperlegible-next-fonts.noarch: E: spelling-error ('kerning', '%description -l en_US kerning -> keening, kenning, yearning')
atkinson-hyperlegible-next-fonts.src: E: spelling-error ('kerning', '%description -l en_US kerning -> keening, kenning, yearning')
atkinson-hyperlegible-next-fonts.spec:52: W: setup-not-quiet
atkinson-hyperlegible-next-fonts-all.noarch: W: no-documentation
 3 packages and 0 specfiles checked; 2 errors, 2 warnings, 11 filtered, 2 badness; has taken 0.5 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 2

atkinson-hyperlegible-next-fonts.noarch: E: spelling-error ('kerning', '%description -l en_US kerning -> keening, kenning, yearning')
atkinson-hyperlegible-next-fonts-all.noarch: W: no-documentation
 2 packages and 0 specfiles checked; 1 errors, 1 warnings, 7 filtered, 1 badness; has taken 0.1 s 



Source checksums
----------------
https://github.com/googlefonts/atkinson-hyperlegible-next/archive/7925f50.tar.gz :
  CHECKSUM(SHA256) this package     : 4b455dcf5ce2d6261df7caf6f4d035c893b446f14269106a07bc03c204368626
  CHECKSUM(SHA256) upstream package : 4b455dcf5ce2d6261df7caf6f4d035c893b446f14269106a07bc03c204368626


Requires
--------
atkinson-hyperlegible-next-fonts (rpmlib, GLIBC filtered):
    config(atkinson-hyperlegible-next-fonts)
    fontpackages-filesystem

atkinson-hyperlegible-next-fonts-all (rpmlib, GLIBC filtered):
    atkinson-hyperlegible-next-fonts



Provides
--------
atkinson-hyperlegible-next-fonts:
    atkinson-hyperlegible-next-fonts
    config(atkinson-hyperlegible-next-fonts)
    font(atkinsonhyperlegiblenext)
    font(atkinsonhyperlegiblenextextrabold)
    font(atkinsonhyperlegiblenextextralight)
    font(atkinsonhyperlegiblenextlight)
    font(atkinsonhyperlegiblenextmedium)
    font(atkinsonhyperlegiblenextsemibold)
    metainfo()
    metainfo(org.fedoraproject.atkinson-hyperlegible-next-fonts.metainfo.xml)

atkinson-hyperlegible-next-fonts-all:
    atkinson-hyperlegible-next-fonts-all



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2369671
Buildroot used: fedora-rawhide-x86_64
Active plugins: fonts, Shell-api, Generic
Disabled plugins: R, Python, SugarActivity, Java, Perl, PHP, Ocaml, C/C++, Haskell
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comments:
a) Please change
%global fontconfngs     %{SOURCE1}
to
%global fontconfs     %{SOURCE1}
b)  Check if Braille institute would register as a vendor:
https://learn.microsoft.com/en-us/typography/vendors/
https://learn.microsoft.com/en-us/typography/vendors/register
They are listed as a vendor at
https://en.wikipedia.org/wiki/Atkinson_Hyperlegible
Raised an issue upstream:
https://github.com/googlefonts/atkinson-hyperlegible/issues/25
c) Please remove
%fontmetapkg
as there is only one package
d) Please remove -a from the macros, it is not needed.
e) Can the variable fonts also be packaged?

Comment 11 Julius Enriquez 2025-08-05 13:20:52 UTC

Updated SPEC URL: https://download.copr.fedorainfracloud.org/results/julicen/atkinson-hyperlegible-fonts/fedora-rawhide-x86_64/09375913-atkinson-hyperlegible-next-fonts/atkinson-hyperlegible-next-fonts.spec
Updated SRPM URL: https://download.copr.fedorainfracloud.org/results/julicen/atkinson-hyperlegible-fonts/fedora-rawhide-x86_64/09375913-atkinson-hyperlegible-next-fonts/atkinson-hyperlegible-next-fonts-2.100-1.fc43.src.rpm

Changes:
* Removed %fontmetapkg
* Removed -a from macros
* Removed %global fontconf and transferred info to SOURCE1
* Changed %global fontconfngs to %global fontconfs

I don't know if the variable fonts can be packaged, since they are in TTF format instead of the OTF format Fedora needs.

Comment 12 Julius Enriquez 2025-08-05 13:28:50 UTC

Koji build task:
https://koji.fedoraproject.org/koji/taskinfo?taskID=135730944

Comment 13 Fedora Review Service 2025-08-06 04:05:15 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/9379760
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2369671-atkinson-hyperlegible-next-fonts/fedora-rawhide-x86_64/09379760-atkinson-hyperlegible-next-fonts/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 14 Julius Enriquez 2025-12-09 04:24:06 UTC

Asking for another review before 2026 ends.

Comment 15 Benson Muite 2025-12-15 11:23:07 UTC

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "SIL Open Font License 1.1", "*No
     copyright* SIL Open Font License 1.1". 50 files have unknown license.
     Detailed output of licensecheck in /home/fedora-
     packaging/reviews/atkinson-hyperlegible-next-fonts/2369671-atkinson-
     hyperlegible-next-fonts/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 903 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define autorelease(e:s:pb:n)
     %{?-p:0.}%{lua:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

fonts:
[!]: Run fc-query on all fonts in package.
     Note: Cannot find fc-query command, install fontconfig package to make
     a comprehensive font review.
     See: url: undefined
[!]: Run repo-font-audit on all fonts in package.
     Note: Cannot find repo-font-audit, install fontpackages-tools package
     to make a comprehensive font review.
     See: url: undefined


Rpmlint
-------
Checking: atkinson-hyperlegible-next-fonts-2.100-1.fc44.noarch.rpm
          atkinson-hyperlegible-next-fonts-2.100-1.fc44.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp3hsdqs2h')]
checks: 32, packages: 2

atkinson-hyperlegible-next-fonts.noarch: E: spelling-error ('kerning', '%description -l en_US kerning -> keening, kenning, yearning')
atkinson-hyperlegible-next-fonts.src: E: spelling-error ('kerning', '%description -l en_US kerning -> keening, kenning, yearning')
atkinson-hyperlegible-next-fonts.spec:50: W: setup-not-quiet
 2 packages and 0 specfiles checked; 2 errors, 1 warnings, 7 filtered, 2 badness; has taken 0.4 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

atkinson-hyperlegible-next-fonts.noarch: E: spelling-error ('kerning', '%description -l en_US kerning -> keening, kenning, yearning')
 1 packages and 0 specfiles checked; 1 errors, 0 warnings, 3 filtered, 1 badness; has taken 0.1 s 



Source checksums
----------------
https://github.com/googlefonts/atkinson-hyperlegible-next/archive/7925f50.tar.gz :
  CHECKSUM(SHA256) this package     : 4b455dcf5ce2d6261df7caf6f4d035c893b446f14269106a07bc03c204368626
  CHECKSUM(SHA256) upstream package : 4b455dcf5ce2d6261df7caf6f4d035c893b446f14269106a07bc03c204368626


Requires
--------
atkinson-hyperlegible-next-fonts (rpmlib, GLIBC filtered):
    config(atkinson-hyperlegible-next-fonts)
    fontpackages-filesystem



Provides
--------
atkinson-hyperlegible-next-fonts:
    atkinson-hyperlegible-next-fonts
    config(atkinson-hyperlegible-next-fonts)
    font(atkinsonhyperlegiblenext)
    font(atkinsonhyperlegiblenextextrabold)
    font(atkinsonhyperlegiblenextextralight)
    font(atkinsonhyperlegiblenextlight)
    font(atkinsonhyperlegiblenextmedium)
    font(atkinsonhyperlegiblenextsemibold)
    metainfo()
    metainfo(org.fedoraproject.atkinson-hyperlegible-next-fonts.metainfo.xml)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2369671
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, fonts, Generic
Disabled plugins: Python, R, Java, PHP, SugarActivity, Perl, Ocaml, C/C++, Haskell
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comments:
a) It seems ok. 
b) Can you try the variable fonts. There could be space savings:
https://fedoraproject.org/wiki/Changes/VariableNotoFonts
https://fedoraproject.org/wiki/Changes/Noto_CJK_Variable_Fonts
ttf should be fine:
https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/
though may need to check if the variable fonts work ok in applications.

Comment 16 Julius Enriquez 2025-12-15 16:56:43 UTC

Tried using the variable TTF font as the general UI font and many strange behaviours began to appear immediately across KDE Plasma and various apps. Hence, it would not be advisable to replace the OTF fonts with the variable font.

Comment 17 Benson Muite 2025-12-15 19:18:32 UTC

Ok. Approved.

Comment 18 Benson Muite 2025-12-17 06:49:06 UTC

Review of https://bugzilla.redhat.com/show_bug.cgi?id=2402460 would be appreciated
if time allows.

Comment 19 Fedora Admin user for bugzilla script actions 2025-12-17 09:38:15 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/atkinson-hyperlegible-next-fonts

Comment 20 Fedora Update System 2025-12-18 09:41:30 UTC

FEDORA-2025-30d747212e (atkinson-hyperlegible-next-fonts-2.100-1.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-30d747212e

Comment 21 Fedora Update System 2025-12-18 09:44:24 UTC

FEDORA-2025-30d747212e (atkinson-hyperlegible-next-fonts-2.100-1.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.