Spec URL: https://download.copr.fedorainfracloud.org/results/julicen/atkinson-hyperlegible-fonts/srpm-builds/09109172/atkinson-hyperlegible-mono.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/julicen/atkinson-hyperlegible-fonts/srpm-builds/09109172/atkinson-hyperlegible-mono-fonts-1.0.0-1.fc42.src.rpm Description: Atkinson Hyperlegible Mono is an entirely new typeface inspired by the Atkinson Hyperlegible font. The monospaced font features characters that each occupy the same amount of horizontal space, allowing for them to be scanned quickly in table-based and coding environments. Fedora Account System Username: julicen This creates packages for Atkinson Hyperlegible Mono, a monospaced typeface created to maximise readability and legibility for people with low-vision. Koji build task: https://koji.fedoraproject.org/koji/taskinfo?taskID=133442364 Related to this request for Atkinson Hyperlegible Next: https://bugzilla.redhat.com/show_bug.cgi?id=2369671 This will be one of my first packages, so a sponsor is needed.
Copr build: https://copr.fedorainfracloud.org/coprs/build/9110219 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2369670-atkinson-hyperlegible-mono-fonts/fedora-rawhide-x86_64/09110219-atkinson-hyperlegible-mono-fonts/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated SPEC URL: https://download.copr.fedorainfracloud.org/results/julicen/atkinson-hyperlegible-fonts/fedora-rawhide-x86_64/09116299-atkinson-hyperlegible-mono-fonts/atkinson-hyperlegible-mono-fonts.spec Updated SRPM URL: https://download.copr.fedorainfracloud.org/results/julicen/atkinson-hyperlegible-fonts/fedora-rawhide-x86_64/09116299-atkinson-hyperlegible-mono-fonts/atkinson-hyperlegible-mono-fonts-2.100-1.fc43.src.rpm Koji build task: https://koji.fedoraproject.org/koji/taskinfo?taskID=133470654 Specfile has been updated with the following changes: * Use of %autochangelog and %autorelease macros * Specfile name now ends with "-fonts" as per the Font Policy of the Packaging Guidelines * Web fonts are no longer packaged * Extraneous "%defattr(0644,root,root,-)" removed
Copr build: https://copr.fedorainfracloud.org/coprs/build/9120489 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2369670-atkinson-hyperlegible-mono-fonts/fedora-rawhide-x86_64/09120489-atkinson-hyperlegible-mono-fonts/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Asking for a follow-up to this review request.
Are there still any further changes needed?
Updated SPEC URL: https://download.copr.fedorainfracloud.org/results/julicen/atkinson-hyperlegible-fonts/fedora-rawhide-x86_64/09359960-atkinson-hyperlegible-mono-fonts/atkinson-hyperlegible-mono-fonts.spec Updated SRPM URL: https://download.copr.fedorainfracloud.org/results/julicen/atkinson-hyperlegible-fonts/fedora-rawhide-x86_64/09359960-atkinson-hyperlegible-mono-fonts/atkinson-hyperlegible-mono-fonts-2.100-1.fc43.src.rpm Specfile has been refactored to be shorter via using more RPM macros. Additionally, there is now only a single package which includes the documentation and license.
Koji build task: https://koji.fedoraproject.org/koji/taskinfo?taskID=135564023
Updated SPEC URL: https://download.copr.fedorainfracloud.org/results/julicen/atkinson-hyperlegible-fonts/fedora-rawhide-x86_64/09375901-atkinson-hyperlegible-mono-fonts/atkinson-hyperlegible-mono-fonts.spec Updated SRPM URL: https://download.copr.fedorainfracloud.org/results/julicen/atkinson-hyperlegible-fonts/fedora-rawhide-x86_64/09375901-atkinson-hyperlegible-mono-fonts/atkinson-hyperlegible-mono-fonts-2.100-1.fc43.src.rpm Changes: * Removed %fontmetapkg * Removed -a from macros * Removed %global fontconf and transferred info to SOURCE1 * Changed %global fontconfngs to %global fontconfs Koji build task: https://koji.fedoraproject.org/koji/taskinfo?taskID=135730920
Created attachment 2102767 [details] The .spec file difference from Copr build 9120489 to 9379762
Copr build: https://copr.fedorainfracloud.org/coprs/build/9379762 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2369670-atkinson-hyperlegible-mono-fonts/fedora-rawhide-x86_64/09379762-atkinson-hyperlegible-mono-fonts/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Asking for another review before 2026 ends.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "SIL Open Font License 1.1", "*No copyright* SIL Open Font License 1.1". 50 files have unknown license. Detailed output of licensecheck in /home/fedora- packaging/reviews/atkinson-hyperlegible-mono-fonts/2369670-atkinson- hyperlegible-mono-fonts/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 977 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://github.com/googlefonts/atkinson-hyperlegible- mono/archive/154d503.tar.gz See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define autorelease(e:s:pb:n) %{?-p:0.}%{lua: [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. fonts: [!]: Run fc-query on all fonts in package. Note: Cannot find fc-query command, install fontconfig package to make a comprehensive font review. See: url: undefined [!]: Run repo-font-audit on all fonts in package. Note: Cannot find repo-font-audit, install fontpackages-tools package to make a comprehensive font review. See: url: undefined Rpmlint ------- Checking: atkinson-hyperlegible-mono-fonts-2.100-1.fc44.noarch.rpm atkinson-hyperlegible-mono-fonts-2.100-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp7v4yho_y')] checks: 32, packages: 2 atkinson-hyperlegible-mono-fonts.noarch: E: spelling-error ('Monospace', 'Summary(en_US) Monospace -> Mono space, Mono-space, Aerospace') atkinson-hyperlegible-mono-fonts.noarch: E: spelling-error ('monospaced', '%description -l en_US monospaced -> mono spaced, mono-spaced, monocled') atkinson-hyperlegible-mono-fonts.src: E: spelling-error ('Monospace', 'Summary(en_US) Monospace -> Mono space, Mono-space, Aerospace') atkinson-hyperlegible-mono-fonts.src: E: spelling-error ('monospaced', '%description -l en_US monospaced -> mono spaced, mono-spaced, monocled') atkinson-hyperlegible-mono-fonts.spec:47: W: setup-not-quiet 2 packages and 0 specfiles checked; 4 errors, 1 warnings, 7 filtered, 4 badness; has taken 0.5 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 atkinson-hyperlegible-mono-fonts.noarch: E: spelling-error ('Monospace', 'Summary(en_US) Monospace -> Mono space, Mono-space, Aerospace') atkinson-hyperlegible-mono-fonts.noarch: E: spelling-error ('monospaced', '%description -l en_US monospaced -> mono spaced, mono-spaced, monocled') 1 packages and 0 specfiles checked; 2 errors, 0 warnings, 3 filtered, 2 badness; has taken 0.1 s Requires -------- atkinson-hyperlegible-mono-fonts (rpmlib, GLIBC filtered): config(atkinson-hyperlegible-mono-fonts) fontpackages-filesystem Provides -------- atkinson-hyperlegible-mono-fonts: atkinson-hyperlegible-mono-fonts config(atkinson-hyperlegible-mono-fonts) font(atkinsonhyperlegiblemono) font(atkinsonhyperlegiblemonoextrabold) font(atkinsonhyperlegiblemonoextralight) font(atkinsonhyperlegiblemonolight) font(atkinsonhyperlegiblemonomedium) font(atkinsonhyperlegiblemonosemibold) metainfo() metainfo(org.fedoraproject.atkinson-hyperlegible-mono-fonts.metainfo.xml) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2369670 Buildroot used: fedora-rawhide-x86_64 Active plugins: fonts, Generic, Shell-api Disabled plugins: Haskell, Ocaml, PHP, Python, SugarActivity, R, Perl, C/C++, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Forge url should be https://github.com/googlefonts/atkinson-hyperlegible-next-mono b) Approved. Please fix (a) before import.
Updated SPEC URL: https://download.copr.fedorainfracloud.org/results/julicen/atkinson-hyperlegible-fonts/fedora-rawhide-x86_64/09911746-atkinson-hyperlegible-mono-fonts/atkinson-hyperlegible-mono-fonts.spec Updated SRPM URL: https://download.copr.fedorainfracloud.org/results/julicen/atkinson-hyperlegible-fonts/fedora-rawhide-x86_64/09911746-atkinson-hyperlegible-mono-fonts/atkinson-hyperlegible-mono-fonts-2.100-1.fc44.src.rpm The forge URL has been fixed, now pointing to the correct repo. Koji build task: https://koji.fedoraproject.org/koji/taskinfo?taskID=140056475
Great. Please go ahead with import.
The Pagure repository was created at https://src.fedoraproject.org/rpms/atkinson-hyperlegible-mono-fonts
FEDORA-2025-1e376d49c2 (atkinson-hyperlegible-mono-fonts-2.100-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2025-1e376d49c2
FEDORA-2025-1e376d49c2 (atkinson-hyperlegible-mono-fonts-2.100-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.