Bug 2373128
| Summary: | Review Request: kmscon - Userspace terminal emulator | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jocelyn Falempe <jfalempe> | ||||||||
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | rawhide | CC: | ngompa13, package-review | ||||||||
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| URL: | https://github.com/Aetf/kmscon/ | ||||||||||
| Whiteboard: | Unretirement | ||||||||||
| Fixed In Version: | Doc Type: | --- | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2025-10-23 01:03:21 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Jocelyn Falempe
2025-06-17 08:45:21 UTC
Taking this review. This needs to be broken up into two reviews: one for kmscon and one for libtsm. Please split this accordingly by following the template[1] and feel free to assign me to both of them. [1]: https://bugzilla.redhat.com/enter_bug.cgi?product=Fedora&format=fedora-review Spec URL: https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-rawhide-x86_64/09238780-kmscon/kmscon.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-rawhide-x86_64/09238780-kmscon/kmscon-9.1.0-1.fc43.src.rpm [fedora-review-service-build] Spec URL: https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-rawhide-x86_64/09238780-kmscon/kmscon.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-rawhide-x86_64/09238780-kmscon/kmscon-9.1.0-1.fc43.src.rpm Created attachment 2096392 [details] changelog entries from suse spec It looks like kmscon's spec is derived from the openSUSE one... See: https://build.opensuse.org/projects/X11:terminals/packages/kmscon/files/kmscon.spec?expand=1 You should probably integrate the changelog entries accordingly too... I've attached properly formatted changelog entries. Spec URL: https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-rawhide-x86_64/09248619-kmscon/kmscon.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-rawhide-x86_64/09248619-kmscon/kmscon-9.1.0-1.fc43.src.rpm [fedora-review-service-build] Spec URL: https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-rawhide-x86_64/09278684-kmscon/kmscon.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-rawhide-x86_64/09278684-kmscon/kmscon-9.1.0-1.fc43.src.rpm I've applied the same changes as the libtsm comment: https://bugzilla.redhat.com/show_bug.cgi?id=2373136#c14 Spec review notes: > # O/P added for 13.1 > Obsoletes: %{name}-service < %{version}-%{release} > Provides: %{name}-service = %{version}-%{release} This should be dropped as it's not relevant to us. > pushd selinux > make install DESTDIR=%{buildroot} > popd This can be replaced with "%make_install -C selinux" As for the changelog, it needs to have all of its entries sorted in reverse chronological order. Spec URL: https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-rawhide-x86_64/09375387-kmscon/kmscon.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-rawhide-x86_64/09375387-kmscon/kmscon-9.1.0-1.fc43.src.rpm Thanks, I've sorted the changelog, and done the other comments. Copr build: https://copr.fedorainfracloud.org/coprs/build/9379752 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2373128-kmscon/fedora-rawhide-x86_64/09379752-kmscon/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. [fedora-review-service-build] Copr build: https://copr.fedorainfracloud.org/coprs/build/9388479 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2373128-kmscon/fedora-rawhide-x86_64/09388479-kmscon/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. [fedora-review-service-build] Copr build: https://copr.fedorainfracloud.org/coprs/build/9389221 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2373128-kmscon/fedora-rawhide-x86_64/09389221-kmscon/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/kmscon Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names - Systemd service file(s) in kmscon Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scriptlets Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. > %{_unitdir}/*.service This should be expanded out, since we need scriptlets here too. > %{_unitdir}/kmscon.service > %{_unitdir}/kmsconvt@.service And scriptlets mentioned in https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scriptlets need to be in the spec. Spec URL: https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-rawhide-x86_64/09403747-kmscon/kmscon.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-rawhide-x86_64/09403747-kmscon/kmscon-9.1.0-1.fc43.src.rpm I've added proper systemd scriptlets, I choose only to reload the service, as restarting the service will break if you're upgrading kmscon from a kmscon console. I also removed the selinux custom rules, because kmscon is now enabled in the global selinux policies: https://github.com/fedora-selinux/selinux-policy/pull/2813 Created attachment 2103350 [details]
The .spec file difference from Copr build 9389221 to 9404928
Copr build: https://copr.fedorainfracloud.org/coprs/build/9404928 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2373128-kmscon/fedora-rawhide-x86_64/09404928-kmscon/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/kmscon Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Gentle ping @ngompa13, can you review the latest version? Thanks, > %build > # Work around https://github.com/Aetf/kmscon/issues/63 > export CFLAGS="%{optflags} $(pkg-config xkbcommon --cflags) $(pkg-config libtsm --cflags) -Wno-error" > %meson -Dtests=false These should be in %conf, unless this package is intended to available in EPEL < 10. See this as an example: https://src.fedoraproject.org/rpms/waynergy/blob/rawhide/f/waynergy.spec Also, why are tests disabled? Is it not possible to run them in %check? Spec URL: https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-rawhide-x86_64/09512390-kmscon/kmscon.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-rawhide-x86_64/09512390-kmscon/kmscon-9.1.0-1.fc44.src.rpm Thanks for the review: I have removed the CLFAGS work around, as it seems it is not needed anymore. I have moved the the %meson in the %conf section and I have added check-devel as BuildRequires, and added: %check %meson_test The kmscon unit test are very minimal (only the "shl" part has some tests), so that's probably why it wasn't enabled. Created attachment 2105492 [details]
The .spec file difference from Copr build 9404928 to 9512416
Copr build: https://copr.fedorainfracloud.org/coprs/build/9512416 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2373128-kmscon/fedora-rawhide-x86_64/09512416-kmscon/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/kmscon Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Review notes: * Package follows Fedora packaging guidelines * Package builds and installs * Package licensing is correct and license data is installed * No serious issues from rpmlint PACKAGE APPROVED. The Pagure repository was created at https://src.fedoraproject.org/rpms/kmscon FEDORA-2025-3600b1d633 (kmscon-9.1.0-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-3600b1d633 FEDORA-2025-3600b1d633 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-3600b1d633 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-3600b1d633 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-b152f08abf (kmscon-9.1.0-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-b152f08abf FEDORA-2025-b152f08abf has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-b152f08abf \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-b152f08abf See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-b152f08abf (kmscon-9.1.0-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-3600b1d633 (kmscon-9.1.0-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report. |