I would like to unretire libtsm Spec URL: https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-rawhide-x86_64/08415350-libtsm/libtsm.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-rawhide-x86_64/08415350-libtsm/libtsm-4.0.2%5E1.git69922bde-0.src.rpm Description: TSM is a state machine for DEC VT100-VT520 compatible terminal emulators. It tries to support all common standards while keeping compatibility to existing emulators like xterm, gnome-terminal, konsole, ... Fedora Account System Username: jfalempe https://src.fedoraproject.org/rpms/libtsm Reproducible: Always
Initial spec review: > Version: 4.0.2^1.git69922bde This should probably be "4.0.2^1.git%{shortcommit}" You might want to macroize the "1" so it's easy to spot to update. > Release: 0 This needs to be set to "1%{?dist}" Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/DistTag/ > Group: Development/Libraries/C and C++ This should be dropped, we don't use the Group tag at all. > Source: https://github.com/Aetf/libtsm/archive/%{commit}/%{name}-%{shortcommit}.tar.gz This can be simplified to "%{url}/archive/%{commit}/%{name}-%{shortcommit}.tar.gz" > %package -n %{lname} We don't typically do this in Fedora, this can be folded back into the main "libtsm" package. > %post -n %{lname} -p /sbin/ldconfig > %postun -n %{lname} -p /sbin/ldconfig This is useless in Fedora since Fedora 28 / RHEL 8. Cf. https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets
Hey, is this spec file derived from another distribution's package? It looks like an openSUSE-style package. If it is, can we please put the openSUSE package changelog entries in here?
I forked it from Michael Bryant (Shadow53) https://copr.fedorainfracloud.org/coprs/shadow53/kmscon/package/libtsm/ From the git history of his repo, I don't see any reference to an opensuse package. Thanks for the review of the spec file, I will make the change. Also I'm trying to make a release upstream, so I don't have to use commit sha. https://github.com/Aetf/kmscon/issues/114
Hmm okay. It's weird because the openSUSE spec looks very similar: https://build.opensuse.org/projects/X11:terminals/packages/libtsm/files/libtsm.spec?expand=1
> Requires: %{lname} = %{version}-%{release} This needs should be "%{name}%{?_isa} = %{version}-%{release}" (assuming the library subpackage is folded back into the main package as suggested).
The ticket summary is not in the correct format. Expected: Review Request: <main package name here> - <short summary here> Found: Review Request libtsm As a consequence, the package name cannot be parsed and submitted to be automatically build. Please modify the ticket summary and trigger a build by typing [fedora-review-service-build]. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
(In reply to Neal Gompa from comment #1) > > > %package -n %{lname} > > We don't typically do this in Fedora, this can be folded back into the main > "libtsm" package. I'm sorry, I'm not sure what to do there. Should I just remove the lines with %{lname} ? I've started a MR with the other requested changes: https://gitlab.com/kdj0c/copr-fedora/-/merge_requests/1/diffs Thanks for fixing the bug title. (In reply to Neal Gompa from comment #4) > Hmm okay. It's weird because the openSUSE spec looks very similar: > https://build.opensuse.org/projects/X11:terminals/packages/libtsm/files/ > libtsm.spec?expand=1 Hum, it looks like he has done some copy/paste from Suse when updating to use Aetf's repo. I can copy the changelogs from here (except the 2025 entry). https://build.opensuse.org/projects/X11:terminals/packages/libtsm/files/libtsm.changes?expand=1