Bug 2373294
| Summary: | Review Request: eswin-firmware - ESWIN Computing early boot firmware | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Yanko Kaneti <yaneti> | ||||
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> | ||||
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | package-review, philip.wyett | ||||
| Target Milestone: | --- | Flags: | philip.wyett:
fedora-review?
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | https://github.com/eswincomputing/Esbd-77serial-firmware/ | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | --- | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | Type: | --- | |||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Yanko Kaneti
2025-06-17 23:02:50 UTC
- Make sure nothing is stripped. Forgot sys Spec URL: http://www.declera.com/~yaneti/eswin-firmware/eswin-firmware.spec SRPM URL: http://www.declera.com/~yaneti/eswin-firmware/eswin-firmware-20250618-7.fc43.src.rpm Copr build: https://copr.fedorainfracloud.org/coprs/build/9178971 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2373294-eswin-firmware/fedora-rawhide-x86_64/09178971-eswin-firmware/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Created attachment 2094229 [details]
The .spec file difference from Copr build 9178971 to 9178977
Copr build: https://copr.fedorainfracloud.org/coprs/build/9178977 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2373294-eswin-firmware/fedora-rawhide-x86_64/09178977-eswin-firmware/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Hi, Thought I would have a look at this one. * No homepage in spec file. Homepage: https://www.eswincomputing.com/en/ * Curious about not installing under 'lib/firmware'? * %changelog for first package should declare 'Initial RPM packaging' or similar. - %changelog entries need to be informative and not short and misleading. Regards Phil (In reply to Phil Wyett from comment #5) > Hi, > > Thought I would have a look at this one. > > * No homepage in spec file. > > Homepage: https://www.eswincomputing.com/en/ Ignore the above, I misread the spec. > > * Curious about not installing under 'lib/firmware'? > > * %changelog for first package should declare 'Initial RPM packaging' or > similar. > > - %changelog entries need to be informative and not short and misleading. > > Regards > > Phil (In reply to Phil Wyett from comment #5) Hello, thanks for taking a look > * Curious about not installing under 'lib/firmware'? If you mean /usr/lib/firmware, that's the location for kernel loaded firmware The eswin firmware is a different kind of firmware that's only usefull as a building block. > * %changelog for first package should declare 'Initial RPM packaging' or > similar. > > - %changelog entries need to be informative and not short and misleading. The spec has %autochangelog , the first entry will be the the git meesage on first commit.. |