Spec URL: http://www.declera.com/~yaneti/eswin-firmware/eswin-firmware.spec SRPM URL: http://www.declera.com/~yaneti/eswin-firmware/eswin-firmware-20250618-6.fc43.src.rpm Description: ESWIN Computing firmware for EIC770x SOCs early boot and eventually other chips Fedora Account System Username: yaneti
- Make sure nothing is stripped. Forgot sys Spec URL: http://www.declera.com/~yaneti/eswin-firmware/eswin-firmware.spec SRPM URL: http://www.declera.com/~yaneti/eswin-firmware/eswin-firmware-20250618-7.fc43.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/9178971 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2373294-eswin-firmware/fedora-rawhide-x86_64/09178971-eswin-firmware/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Created attachment 2094229 [details] The .spec file difference from Copr build 9178971 to 9178977
Copr build: https://copr.fedorainfracloud.org/coprs/build/9178977 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2373294-eswin-firmware/fedora-rawhide-x86_64/09178977-eswin-firmware/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Hi, Thought I would have a look at this one. * No homepage in spec file. Homepage: https://www.eswincomputing.com/en/ * Curious about not installing under 'lib/firmware'? * %changelog for first package should declare 'Initial RPM packaging' or similar. - %changelog entries need to be informative and not short and misleading. Regards Phil
(In reply to Phil Wyett from comment #5) > Hi, > > Thought I would have a look at this one. > > * No homepage in spec file. > > Homepage: https://www.eswincomputing.com/en/ Ignore the above, I misread the spec. > > * Curious about not installing under 'lib/firmware'? > > * %changelog for first package should declare 'Initial RPM packaging' or > similar. > > - %changelog entries need to be informative and not short and misleading. > > Regards > > Phil
(In reply to Phil Wyett from comment #5) Hello, thanks for taking a look > * Curious about not installing under 'lib/firmware'? If you mean /usr/lib/firmware, that's the location for kernel loaded firmware The eswin firmware is a different kind of firmware that's only usefull as a building block. > * %changelog for first package should declare 'Initial RPM packaging' or > similar. > > - %changelog entries need to be informative and not short and misleading. The spec has %autochangelog , the first entry will be the the git meesage on first commit..