Bug 237332
| Summary: | Review Request: perl-Crypt-OpenSSL-Bignum -- Perl OpenSSL bindings for big numbers support | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Wes Hardaker <wjhns174> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | Flags: | j:
fedora-review+
dennis: fedora-cvs+ |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-05-22 23:49:54 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 237338 | ||
|
Description
Wes Hardaker
2007-04-20 20:34:20 UTC
Please post SRPM. Spec URL: http://www.hardakers.net/FE/perl-Crypt-OpenSSL-Bignum.spec SRPM URL: http://www.hardakers.net/FE/perl-Crypt-OpenSSL-Bignum-0.03-1.src.rpm whoops. Spec URL: http://www.hardakers.net/FE/perl-Crypt-OpenSSL-Bignum.spec SRPM URL: http://www.hardakers.net/FE/perl-Crypt-OpenSSL-Bignum-0.03-2.src.rpm - Add BuildRequire openssl-devel - Don't manually require openssl - Use vendorarch instead of vendorlib As should be expected now, this needs BuildRequires: perl(ExtUtils::MakeMaker). The test suite needs perl(Test) but I'm really not sure if the plan is to split that off or not. Really, that's the only issue I see with this package. Let me go over one more tonight and then we can start getting some of these checked in. * source files match upstream: d709ce87110f0f1ab1c9d957f11239d5c4e411733b0e6ea08576720e1f147c80 Crypt-OpenSSL-Bignum-0.03.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: Bignum.so()(64bit) perl(Crypt::OpenSSL::Bignum) = 0.03 perl(Crypt::OpenSSL::Bignum::CTX) perl-Crypt-OpenSSL-Bignum = 0.03-2.fc7 = libcrypto.so.6()(64bit) perl >= 0:5.005 perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Crypt::OpenSSL::Bignum) perl(DynaLoader) perl(strict) perl(vars) * %check is present and all tests pass: [...] ok 52 + exit 0 * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la droppings. Spec URL: http://www.hardakers.net/FE/perl-Crypt-OpenSSL-Bignum.spec SRPM URL: http://www.hardakers.net/FE/perl-Crypt-OpenSSL-Bignum-0.03-3.src.rpm * Mon May 14 2007 Wes Hardaker <wjhns174> - 0.03-3 - BuildRequire perl(ExtUtils::MakeMaker) perl(Test) Looks good to me. APPROVED New Package CVS Request ======================= Package Name: perl-Crypt-OpenSSL-Bignum Short Description: Perl OpenSSL bindings for big numbers support Owners: wjhns174 Branches: FC-6 F-7 InitialCC: cvs done. Package Change Request ====================== Package Name: perl-Crypt-OpenSSL-Bignum New Branches: EL-4 EL-5 CVS Done |