Bug 237332 - Review Request: perl-Crypt-OpenSSL-Bignum -- Perl OpenSSL bindings for big numbers support
Review Request: perl-Crypt-OpenSSL-Bignum -- Perl OpenSSL bindings for big n...
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jason Tibbitts
Fedora Package Reviews List
Depends On:
Blocks: perl-Net-DNS-SEC
  Show dependency treegraph
Reported: 2007-04-20 16:34 EDT by Wes Hardaker
Modified: 2008-06-16 16:52 EDT (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-05-22 19:49:54 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
tibbs: fedora‑review+
dennis: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Wes Hardaker 2007-04-20 16:34:20 EDT
Spec URL: http://www.hardakers.net/FE/perl-Crypt-OpenSSL-Bignum.spec
SRPM URL: http://www.hardakers.net/FE/perl-Crypt-OpenSSL-Bignum.spec
Description:  A Perl wrapper around OpenSSL's big-number support.

(I don't currently have a sponsor, although there are other packages
I've submitted as well tagged as needing a sponsor as well).
Comment 1 Bernard Johnson 2007-04-30 13:15:21 EDT
Please post SRPM.
Comment 3 Wes Hardaker 2007-05-08 16:57:41 EDT
Spec URL: http://www.hardakers.net/FE/perl-Crypt-OpenSSL-Bignum.spec
SRPM URL: http://www.hardakers.net/FE/perl-Crypt-OpenSSL-Bignum-0.03-2.src.rpm

- Add BuildRequire openssl-devel
- Don't manually require openssl
- Use vendorarch instead of vendorlib
Comment 4 Jason Tibbitts 2007-05-09 22:37:33 EDT
As should be expected now, this needs BuildRequires: perl(ExtUtils::MakeMaker).
 The test suite needs perl(Test) but I'm really not sure if the plan is to split
that off or not.

Really, that's the only issue I see with this package.  Let me go over one more
tonight and then we can start getting some of these checked in.

* source files match upstream:
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
   perl(Crypt::OpenSSL::Bignum) = 0.03
   perl-Crypt-OpenSSL-Bignum = 0.03-2.fc7
   perl >= 0:5.005

* %check is present and all tests pass:
   ok 52
   + exit 0

* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la droppings.
Comment 5 Wes Hardaker 2007-05-14 18:01:18 EDT
Spec URL: http://www.hardakers.net/FE/perl-Crypt-OpenSSL-Bignum.spec
SRPM URL: http://www.hardakers.net/FE/perl-Crypt-OpenSSL-Bignum-0.03-3.src.rpm

* Mon May 14 2007  Wes Hardaker <wjhns174@hardakers.net> - 0.03-3
- BuildRequire perl(ExtUtils::MakeMaker) perl(Test)
Comment 6 Jason Tibbitts 2007-05-15 14:24:25 EDT
Looks good to me.

Comment 7 Wes Hardaker 2007-05-22 16:24:56 EDT
New Package CVS Request
Package Name: perl-Crypt-OpenSSL-Bignum
Short Description: Perl OpenSSL bindings for big numbers support
Owners: wjhns174@hardakers.net
Branches: FC-6 F-7
Comment 8 Tom "spot" Callaway 2007-05-22 18:02:10 EDT
cvs done.
Comment 9 Wes Hardaker 2008-06-16 16:36:18 EDT
Package Change Request
Package Name: perl-Crypt-OpenSSL-Bignum
New Branches: EL-4 EL-5
Comment 10 Dennis Gilmore 2008-06-16 16:52:44 EDT
CVS Done

Note You need to log in before you can comment on or make changes to this bug.