Bug 2375073
| Summary: | Review Request: fedora-eln-logos - Fedora-ELN-related icons and pictures | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Troy Dawson <tdawson> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | ngompa13, package-review, yselkowi |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2025-07-09 16:44:14 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Troy Dawson
2025-06-26 21:30:49 UTC
Note: The Source line currently does not work because I have not released version 1.0 yet. I'm waiting for this review to see if anyone thinks I've missed anything yet. Taking this review. This needs to Obsoletes fedora-logos to provide an upgrade path. centos-logos doesn't Provides fedora-logos though, so this probably shouldn't either. (In reply to Yaakov Selkowitz from comment #3) > This needs to Obsoletes fedora-logos to provide an upgrade path. > centos-logos doesn't Provides fedora-logos though, so this probably > shouldn't either. No, it does not and should not. It should have Conflicts with fedora-logos, though. > Source0: https://github.com/fedora-eln/%{short_name}/archive/refs/tags/%{version}.tar.gz This should be fixed to "https://github.com/fedora-eln/%{short_name}/archive/%{version}/%{short_name}-%{version}.tar.gz" I have added "Conflicts: fedora-logos" I have changed the source to "Source0: https://github.com/fedora-eln/%{short_name}/archive/%{version}/%{short_name}-%{version}.tar.gz" I have also tagged and released version 1.0 in the github repo, so that source URL is correct. Looks good to me now. PACKAGE APPROVED. Erk, forgot to post review notes: Review notes: * Package follows packaging guidelines * Package licensing is correct and valid, with license data being installed * Package builds and installs * No serious issues from rpmlint The Pagure repository was created at https://src.fedoraproject.org/rpms/fedora-eln-logos This has been built and is in the latest ELN compose. |