Spec URL: https://tdawson.fedorapeople.org/review/fedora-eln-logos/fedora-eln-logos.spec SRPM URL: https://tdawson.fedorapeople.org/review/fedora-eln-logos/fedora-eln-logos-1.0-1.el10.src.rpm Description: The fedora-eln-logos-httpd package contains image files which incorporate the Fedora ELN logo. Fedora Account System Username: tdawson
Note: The Source line currently does not work because I have not released version 1.0 yet. I'm waiting for this review to see if anyone thinks I've missed anything yet.
Taking this review.
This needs to Obsoletes fedora-logos to provide an upgrade path. centos-logos doesn't Provides fedora-logos though, so this probably shouldn't either.
(In reply to Yaakov Selkowitz from comment #3) > This needs to Obsoletes fedora-logos to provide an upgrade path. > centos-logos doesn't Provides fedora-logos though, so this probably > shouldn't either. No, it does not and should not.
It should have Conflicts with fedora-logos, though.
> Source0: https://github.com/fedora-eln/%{short_name}/archive/refs/tags/%{version}.tar.gz This should be fixed to "https://github.com/fedora-eln/%{short_name}/archive/%{version}/%{short_name}-%{version}.tar.gz"
I have added "Conflicts: fedora-logos" I have changed the source to "Source0: https://github.com/fedora-eln/%{short_name}/archive/%{version}/%{short_name}-%{version}.tar.gz" I have also tagged and released version 1.0 in the github repo, so that source URL is correct.
Looks good to me now. PACKAGE APPROVED.
Erk, forgot to post review notes: Review notes: * Package follows packaging guidelines * Package licensing is correct and valid, with license data being installed * Package builds and installs * No serious issues from rpmlint
The Pagure repository was created at https://src.fedoraproject.org/rpms/fedora-eln-logos
This has been built and is in the latest ELN compose.